[PATCH 2.6.25-rc6-git2] drm: fix printk format warning - Kernel

This is a discussion on [PATCH 2.6.25-rc6-git2] drm: fix printk format warning - Kernel ; From: Randy Dunlap Fix gcc printk format warning: drivers/char/drm/ati_pcigart.c:125: warning: format '%08X' expects type 'unsigned int', but argument 3 has type 'dma_addr_t' but doesn't the %08 leave room for truncation? Signed-off-by: Randy Dunlap --- drivers/char/drm/ati_pcigart.c | 5 +++-- 1 file ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH 2.6.25-rc6-git2] drm: fix printk format warning

  1. [PATCH 2.6.25-rc6-git2] drm: fix printk format warning

    From: Randy Dunlap

    Fix gcc printk format warning:
    drivers/char/drm/ati_pcigart.c:125: warning: format '%08X' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'

    but doesn't the %08 leave room for truncation?

    Signed-off-by: Randy Dunlap
    ---
    drivers/char/drm/ati_pcigart.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    --- linux-2.6.25-rc6-git2.orig/drivers/char/drm/ati_pcigart.c
    +++ linux-2.6.25-rc6-git2/drivers/char/drm/ati_pcigart.c
    @@ -122,8 +122,9 @@ int drm_ati_pcigart_init(struct drm_devi
    } else {
    address = gart_info->addr;
    bus_address = gart_info->bus_addr;
    - DRM_DEBUG("PCI: Gart Table: VRAM %08X mapped at %08lX\n",
    - bus_address, (unsigned long)address);
    + DRM_DEBUG("PCI: Gart Table: VRAM %08llX mapped at %08lX\n",
    + (unsigned long long)bus_address,
    + (unsigned long)address);
    }

    pci_gart = (u32 *) address;
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH 2.6.25-rc6-git2] drm: fix printk format warning

    ping.


    On Tue, 18 Mar 2008 14:14:11 -0700 Randy Dunlap wrote:

    > From: Randy Dunlap
    >
    > Fix gcc printk format warning:
    > drivers/char/drm/ati_pcigart.c:125: warning: format '%08X' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
    >
    > but doesn't the %08 leave room for truncation?
    >
    > Signed-off-by: Randy Dunlap
    > ---
    > drivers/char/drm/ati_pcigart.c | 5 +++--
    > 1 file changed, 3 insertions(+), 2 deletions(-)
    >
    > --- linux-2.6.25-rc6-git2.orig/drivers/char/drm/ati_pcigart.c
    > +++ linux-2.6.25-rc6-git2/drivers/char/drm/ati_pcigart.c
    > @@ -122,8 +122,9 @@ int drm_ati_pcigart_init(struct drm_devi
    > } else {
    > address = gart_info->addr;
    > bus_address = gart_info->bus_addr;
    > - DRM_DEBUG("PCI: Gart Table: VRAM %08X mapped at %08lX\n",
    > - bus_address, (unsigned long)address);
    > + DRM_DEBUG("PCI: Gart Table: VRAM %08llX mapped at %08lX\n",
    > + (unsigned long long)bus_address,
    > + (unsigned long)address);
    > }
    >
    > pci_gart = (u32 *) address;
    > --


    ---
    ~Randy
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread