[PATCH] ehea: Fix IPv6 support - Kernel

This is a discussion on [PATCH] ehea: Fix IPv6 support - Kernel ; Indicate that HEA calculates IPv4 checksums only Signed-off-by: Thomas Klein --- diff -Nurp -X dontdiff linux-2.6.25-rc6/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/ehea.h --- linux-2.6.25-rc6/drivers/net/ehea/ehea.h 2008-03-17 00:32:14.000000000 +0100 +++ patched_kernel/drivers/net/ehea/ehea.h 2008-03-19 08:58:07.000000000 +0100 @@ -40,7 +40,7 @@ #include #define DRV_NAME "ehea" -#define DRV_VERSION "EHEA_0087" +#define DRV_VERSION ...

+ Reply to Thread
Results 1 to 4 of 4

Thread: [PATCH] ehea: Fix IPv6 support

  1. [PATCH] ehea: Fix IPv6 support

    Indicate that HEA calculates IPv4 checksums only

    Signed-off-by: Thomas Klein

    ---
    diff -Nurp -X dontdiff linux-2.6.25-rc6/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/ehea.h
    --- linux-2.6.25-rc6/drivers/net/ehea/ehea.h 2008-03-17 00:32:14.000000000 +0100
    +++ patched_kernel/drivers/net/ehea/ehea.h 2008-03-19 08:58:07.000000000 +0100
    @@ -40,7 +40,7 @@
    #include

    #define DRV_NAME "ehea"
    -#define DRV_VERSION "EHEA_0087"
    +#define DRV_VERSION "EHEA_0089"

    /* eHEA capability flags */
    #define DLPAR_PORT_ADD_REM 1
    diff -Nurp -X dontdiff linux-2.6.25-rc6/drivers/net/ehea/ehea_main.c patched_kernel/drivers/net/ehea/ehea_main.c
    --- linux-2.6.25-rc6/drivers/net/ehea/ehea_main.c 2008-03-17 00:32:14.000000000 +0100
    +++ patched_kernel/drivers/net/ehea/ehea_main.c 2008-03-19 08:58:07.000000000 +0100
    @@ -3108,7 +3108,7 @@ struct ehea_port *ehea_setup_single_port
    dev->vlan_rx_add_vid = ehea_vlan_rx_add_vid;
    dev->vlan_rx_kill_vid = ehea_vlan_rx_kill_vid;
    dev->features = NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_TSO
    - | NETIF_F_HIGHDMA | NETIF_F_HW_CSUM | NETIF_F_HW_VLAN_TX
    + | NETIF_F_HIGHDMA | NETIF_F_IP_CSUM | NETIF_F_HW_VLAN_TX
    | NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_FILTER
    | NETIF_F_LLTX;
    dev->tx_timeout = &ehea_tx_watchdog;
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] ehea: Fix IPv6 support

    On Wed, 19 Mar 2008 13:55:43 +0100
    Thomas Klein wrote:

    > Indicate that HEA calculates IPv4 checksums only
    >
    > Signed-off-by: Thomas Klein
    >
    > ---
    > diff -Nurp -X dontdiff linux-2.6.25-rc6/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/ehea.h
    > --- linux-2.6.25-rc6/drivers/net/ehea/ehea.h 2008-03-17 00:32:14.000000000 +0100
    > +++ patched_kernel/drivers/net/ehea/ehea.h 2008-03-19 08:58:07.000000000 +0100
    > @@ -40,7 +40,7 @@
    > #include
    >
    > #define DRV_NAME "ehea"
    > -#define DRV_VERSION "EHEA_0087"
    > +#define DRV_VERSION "EHEA_0089"
    >
    > /* eHEA capability flags */
    > #define DLPAR_PORT_ADD_REM 1
    > diff -Nurp -X dontdiff linux-2.6.25-rc6/drivers/net/ehea/ehea_main.c patched_kernel/drivers/net/ehea/ehea_main.c
    > --- linux-2.6.25-rc6/drivers/net/ehea/ehea_main.c 2008-03-17 00:32:14.000000000 +0100
    > +++ patched_kernel/drivers/net/ehea/ehea_main.c 2008-03-19 08:58:07.000000000 +0100
    > @@ -3108,7 +3108,7 @@ struct ehea_port *ehea_setup_single_port
    > dev->vlan_rx_add_vid = ehea_vlan_rx_add_vid;
    > dev->vlan_rx_kill_vid = ehea_vlan_rx_kill_vid;
    > dev->features = NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_TSO
    > - | NETIF_F_HIGHDMA | NETIF_F_HW_CSUM | NETIF_F_HW_VLAN_TX
    > + | NETIF_F_HIGHDMA | NETIF_F_IP_CSUM | NETIF_F_HW_VLAN_TX
    > | NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_FILTER
    > | NETIF_F_LLTX;
    > dev->tx_timeout = &ehea_tx_watchdog;


    That looks like a pretty significant fix to me? Should it be backported to
    2.6.24.x?
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] ehea: Fix IPv6 support

    Andrew Morton wrote:
    > On Wed, 19 Mar 2008 13:55:43 +0100
    > Thomas Klein wrote:
    >
    >> Indicate that HEA calculates IPv4 checksums only
    >>
    >> Signed-off-by: Thomas Klein
    >>
    >> ---
    >> diff -Nurp -X dontdiff linux-2.6.25-rc6/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/ehea.h
    >> --- linux-2.6.25-rc6/drivers/net/ehea/ehea.h 2008-03-17 00:32:14.000000000 +0100
    >> +++ patched_kernel/drivers/net/ehea/ehea.h 2008-03-19 08:58:07.000000000 +0100
    >> @@ -40,7 +40,7 @@
    >> #include
    >>
    >> #define DRV_NAME "ehea"
    >> -#define DRV_VERSION "EHEA_0087"
    >> +#define DRV_VERSION "EHEA_0089"
    >>
    >> /* eHEA capability flags */
    >> #define DLPAR_PORT_ADD_REM 1
    >> diff -Nurp -X dontdiff linux-2.6.25-rc6/drivers/net/ehea/ehea_main.c patched_kernel/drivers/net/ehea/ehea_main.c
    >> --- linux-2.6.25-rc6/drivers/net/ehea/ehea_main.c 2008-03-17 00:32:14.000000000 +0100
    >> +++ patched_kernel/drivers/net/ehea/ehea_main.c 2008-03-19 08:58:07.000000000 +0100
    >> @@ -3108,7 +3108,7 @@ struct ehea_port *ehea_setup_single_port
    >> dev->vlan_rx_add_vid = ehea_vlan_rx_add_vid;
    >> dev->vlan_rx_kill_vid = ehea_vlan_rx_kill_vid;
    >> dev->features = NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_TSO
    >> - | NETIF_F_HIGHDMA | NETIF_F_HW_CSUM | NETIF_F_HW_VLAN_TX
    >> + | NETIF_F_HIGHDMA | NETIF_F_IP_CSUM | NETIF_F_HW_VLAN_TX
    >> | NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_FILTER
    >> | NETIF_F_LLTX;
    >> dev->tx_timeout = &ehea_tx_watchdog;

    >
    > That looks like a pretty significant fix to me? Should it be backported to
    > 2.6.24.x?


    Agreed. I'll send a patch.

    Thomas
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [PATCH] ehea: Fix IPv6 support

    Thomas Klein wrote:
    > Indicate that HEA calculates IPv4 checksums only
    >
    > Signed-off-by: Thomas Klein
    >
    > ---
    > diff -Nurp -X dontdiff linux-2.6.25-rc6/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/ehea.h
    > --- linux-2.6.25-rc6/drivers/net/ehea/ehea.h 2008-03-17 00:32:14.000000000 +0100
    > +++ patched_kernel/drivers/net/ehea/ehea.h 2008-03-19 08:58:07.000000000 +0100
    > @@ -40,7 +40,7 @@
    > #include
    >
    > #define DRV_NAME "ehea"
    > -#define DRV_VERSION "EHEA_0087"
    > +#define DRV_VERSION "EHEA_0089"
    >
    > /* eHEA capability flags */
    > #define DLPAR_PORT_ADD_REM 1
    > diff -Nurp -X dontdiff linux-2.6.25-rc6/drivers/net/ehea/ehea_main.c patched_kernel/drivers/net/ehea/ehea_main.c
    > --- linux-2.6.25-rc6/drivers/net/ehea/ehea_main.c 2008-03-17 00:32:14.000000000 +0100
    > +++ patched_kernel/drivers/net/ehea/ehea_main.c 2008-03-19 08:58:07.000000000 +0100
    > @@ -3108,7 +3108,7 @@ struct ehea_port *ehea_setup_single_port
    > dev->vlan_rx_add_vid = ehea_vlan_rx_add_vid;
    > dev->vlan_rx_kill_vid = ehea_vlan_rx_kill_vid;
    > dev->features = NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_TSO
    > - | NETIF_F_HIGHDMA | NETIF_F_HW_CSUM | NETIF_F_HW_VLAN_TX
    > + | NETIF_F_HIGHDMA | NETIF_F_IP_CSUM | NETIF_F_HW_VLAN_TX
    > | NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_FILTER


    applied


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread