[PATCH 1/3] watchdog: Make w83697h_wdt void-like functions void - Kernel

This is a discussion on [PATCH 1/3] watchdog: Make w83697h_wdt void-like functions void - Kernel ; Signed-off-by: Samuel Tardieu --- drivers/watchdog/w83697hf_wdt.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/watchdog/w83697hf_wdt.c b/drivers/watchdog/w83697hf_wdt.c index b534174..2120702 100644 --- a/drivers/watchdog/w83697hf_wdt.c +++ b/drivers/watchdog/w83697hf_wdt.c @@ -56,7 +56,7 @@ module_param(timeout, int, 0); static int timeout = WATCHDOG_TIMEOUT; /* in ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH 1/3] watchdog: Make w83697h_wdt void-like functions void

  1. [PATCH 2/3] watchdog: Make w83697h_wdt timeout option string similar to others

    Signed-off-by: Samuel Tardieu
    ---
    drivers/watchdog/w83697hf_wdt.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/watchdog/w83697hf_wdt.c b/drivers/watchdog/w83697hf_wdt.c
    index b534174..2120702 100644
    --- a/drivers/watchdog/w83697hf_wdt.c
    +++ b/drivers/watchdog/w83697hf_wdt.c
    @@ -56,7 +56,7 @@ module_param(timeout, int, 0);

    static int timeout = WATCHDOG_TIMEOUT; /* in seconds */
    module_param(timeout, int, 0);
    -MODULE_PARM_DESC(timeout, "Watchdog timeout in seconds. 1<= timeout <=255, default=" __MODULE_STRING(WATCHDOG_TIMEOUT) ".");
    +MODULE_PARM_DESC(timeout, "Watchdog timeout in seconds. 1<= timeout <=255 (default=" __MODULE_STRING(WATCHDOG_TIMEOUT) ")");

    static int nowayout = WATCHDOG_NOWAYOUT;
    module_param(nowayout, int, 0);
    --
    1.5.4.3.611.g29c00.dirty

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. [PATCH 1/3] watchdog: Make w83697h_wdt void-like functions void

    Some non-exported functions always returned 0. Mark them void instead.

    Signed-off-by: Samuel Tardieu
    ---
    drivers/watchdog/w83697hf_wdt.c | 9 +++------
    1 files changed, 3 insertions(+), 6 deletions(-)

    diff --git a/drivers/watchdog/w83697hf_wdt.c b/drivers/watchdog/w83697hf_wdt.c
    index c622a0e..b534174 100644
    --- a/drivers/watchdog/w83697hf_wdt.c
    +++ b/drivers/watchdog/w83697hf_wdt.c
    @@ -140,7 +140,7 @@ w83697hf_init(void)
    w83697hf_deselect_wdt();
    }

    -static int
    +static void
    wdt_ping(void)
    {
    spin_lock(&io_lock);
    @@ -150,10 +150,9 @@ wdt_ping(void)

    w83697hf_deselect_wdt();
    spin_unlock(&io_lock);
    - return 0;
    }

    -static int
    +static void
    wdt_enable(void)
    {
    spin_lock(&io_lock);
    @@ -164,10 +163,9 @@ wdt_enable(void)

    w83697hf_deselect_wdt();
    spin_unlock(&io_lock);
    - return 0;
    }

    -static int
    +static void
    wdt_disable(void)
    {
    spin_lock(&io_lock);
    @@ -178,7 +176,6 @@ wdt_disable(void)

    w83697hf_deselect_wdt();
    spin_unlock(&io_lock);
    - return 0;
    }

    static int
    --
    1.5.4.3.611.g29c00.dirty

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread