[PATCH] x86: parocessor.h - use PAGE_SIZE instead of numeric constant - Kernel

This is a discussion on [PATCH] x86: parocessor.h - use PAGE_SIZE instead of numeric constant - Kernel ; This patch replaces numeric constant with an appropriate macro Signed-off-by: Cyrill Gorcunov --- Index: linux-2.6.git/include/asm-x86/processor.h ================================================== ================= --- linux-2.6.git.orig/include/asm-x86/processor.h 2008-02-20 19:14:57.000000000 +0300 +++ linux-2.6.git/include/asm-x86/processor.h 2008-03-12 23:10:02.000000000 +0300 @@ -786,7 +786,7 @@ extern unsigned long thread_saved_pc(str /* * User space process ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: [PATCH] x86: parocessor.h - use PAGE_SIZE instead of numeric constant

  1. [PATCH] x86: parocessor.h - use PAGE_SIZE instead of numeric constant

    This patch replaces numeric constant with an appropriate macro

    Signed-off-by: Cyrill Gorcunov

    ---

    Index: linux-2.6.git/include/asm-x86/processor.h
    ================================================== =================
    --- linux-2.6.git.orig/include/asm-x86/processor.h 2008-02-20 19:14:57.000000000 +0300
    +++ linux-2.6.git/include/asm-x86/processor.h 2008-03-12 23:10:02.000000000 +0300
    @@ -786,7 +786,7 @@ extern unsigned long thread_saved_pc(str
    /*
    * User space process size. 47bits minus one guard page.
    */
    -#define TASK_SIZE64 (0x800000000000UL - 4096)
    +#define TASK_SIZE64 (0x800000000000UL - PAGE_SIZE)

    /* This decides where the kernel will search for a free chunk of vm
    * space during mmap's.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] x86: parocessor.h - use PAGE_SIZE instead of numeric constant

    Cyrill Gorcunov wrote:
    > This patch replaces numeric constant with an appropriate macro
    >
    > Signed-off-by: Cyrill Gorcunov
    >
    > ---
    >
    > Index: linux-2.6.git/include/asm-x86/processor.h
    > ================================================== =================
    > --- linux-2.6.git.orig/include/asm-x86/processor.h 2008-02-20 19:14:57.000000000 +0300
    > +++ linux-2.6.git/include/asm-x86/processor.h 2008-03-12 23:10:02.000000000 +0300
    > @@ -786,7 +786,7 @@ extern unsigned long thread_saved_pc(str
    > /*
    > * User space process size. 47bits minus one guard page.
    > */
    > -#define TASK_SIZE64 (0x800000000000UL - 4096)
    > +#define TASK_SIZE64 (0x800000000000UL - PAGE_SIZE)
    >
    > /* This decides where the kernel will search for a free chunk of vm
    > * space during mmap's.


    Although I'd personally prefer ((1UL << 47) - PAGE_SIZE)

    -hpa
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] x86: parocessor.h - use PAGE_SIZE instead of numeric constant

    Yep, it wold be more elegant, i'll fix it tomorrow. (sorry for
    top-posting, i'm not on my local laptop now)

    On 3/13/08, H. Peter Anvin wrote:
    > Cyrill Gorcunov wrote:
    > > This patch replaces numeric constant with an appropriate macro
    > >
    > > Signed-off-by: Cyrill Gorcunov
    > >
    > > ---
    > >
    > > Index: linux-2.6.git/include/asm-x86/processor.h
    > > ================================================== =================
    > > --- linux-2.6.git.orig/include/asm-x86/processor.h 2008-02-20

    > 19:14:57.000000000 +0300
    > > +++ linux-2.6.git/include/asm-x86/processor.h 2008-03-12

    > 23:10:02.000000000 +0300
    > > @@ -786,7 +786,7 @@ extern unsigned long thread_saved_pc(str
    > > /*
    > > * User space process size. 47bits minus one guard page.
    > > */
    > > -#define TASK_SIZE64 (0x800000000000UL - 4096)
    > > +#define TASK_SIZE64 (0x800000000000UL - PAGE_SIZE)
    > >
    > > /* This decides where the kernel will search for a free chunk of vm
    > > * space during mmap's.

    >
    > Although I'd personally prefer ((1UL << 47) - PAGE_SIZE)
    >
    > -hpa
    >

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread