[PATCH -mm] do not check condition twice in WARN_ON_SECS - Kernel

This is a discussion on [PATCH -mm] do not check condition twice in WARN_ON_SECS - Kernel ; Don't check condition twice, change WARN_ON(condition) to WARN_ON(1) Thanks Marcin Slusarz for pointing out Signed-off-by: Dave Young --- include/asm-generic/bug.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -upr linux/include/asm-generic/bug.h linux.new/include/asm-generic/bug.h --- linux/include/asm-generic/bug.h 2008-03-12 08:45:08.000000000 +0800 +++ linux.new/include/asm-generic/bug.h ...

+ Reply to Thread
Results 1 to 4 of 4

Thread: [PATCH -mm] do not check condition twice in WARN_ON_SECS

  1. [PATCH -mm] do not check condition twice in WARN_ON_SECS

    Don't check condition twice, change WARN_ON(condition) to WARN_ON(1)
    Thanks Marcin Slusarz for pointing out

    Signed-off-by: Dave Young

    ---
    include/asm-generic/bug.h | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff -upr linux/include/asm-generic/bug.h linux.new/include/asm-generic/bug.h
    --- linux/include/asm-generic/bug.h 2008-03-12 08:45:08.000000000 +0800
    +++ linux.new/include/asm-generic/bug.h 2008-03-12 09:04:07.000000000 +0800
    @@ -80,7 +80,8 @@ extern void warn_on_slowpath(const char
    int __ret_warn_on = !!(condition); \
    if (unlikely(__ret_warn_on)) \
    if (__ratelimit(secs * HZ, 1)) \
    - WARN_ON(condition); \
    + WARN_ON(1); \
    + unlikely(__ret_warn_on); \
    })

    #ifdef CONFIG_SMP
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH -mm] do not check condition twice in WARN_ON_SECS

    Hi Dave,

    Dave Young writes:

    > Don't check condition twice, change WARN_ON(condition) to WARN_ON(1)
    > Thanks Marcin Slusarz for pointing out
    >
    > Signed-off-by: Dave Young
    >
    > ---
    > include/asm-generic/bug.h | 3 ++-
    > 1 file changed, 2 insertions(+), 1 deletion(-)
    >
    > diff -upr linux/include/asm-generic/bug.h linux.new/include/asm-generic/bug.h
    > --- linux/include/asm-generic/bug.h 2008-03-12 08:45:08.000000000 +0800
    > +++ linux.new/include/asm-generic/bug.h 2008-03-12 09:04:07.000000000 +0800
    > @@ -80,7 +80,8 @@ extern void warn_on_slowpath(const char
    > int __ret_warn_on = !!(condition); \
    > if (unlikely(__ret_warn_on)) \
    > if (__ratelimit(secs * HZ, 1)) \
    > - WARN_ON(condition); \
    > + WARN_ON(1); \
    > + unlikely(__ret_warn_on); \
    > })


    What's wrong with:

    #define WARN_ON_SECS(condition, secs) \
    WARN_ON(condition && __ratelimit(secs * HZ, 1))

    ?

    Hannes
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH -mm] do not check condition twice in WARN_ON_SECS

    On Wed, Mar 12, 2008 at 9:47 PM, Johannes Weiner wrote:
    > Hi Dave,
    >
    >
    >
    > Dave Young writes:
    >
    > > Don't check condition twice, change WARN_ON(condition) to WARN_ON(1)
    > > Thanks Marcin Slusarz for pointing out
    > >
    > > Signed-off-by: Dave Young
    > >
    > > ---
    > > include/asm-generic/bug.h | 3 ++-
    > > 1 file changed, 2 insertions(+), 1 deletion(-)
    > >
    > > diff -upr linux/include/asm-generic/bug.h linux.new/include/asm-generic/bug.h
    > > --- linux/include/asm-generic/bug.h 2008-03-12 08:45:08.000000000 +0800
    > > +++ linux.new/include/asm-generic/bug.h 2008-03-12 09:04:07.000000000 +0800
    > > @@ -80,7 +80,8 @@ extern void warn_on_slowpath(const char
    > > int __ret_warn_on = !!(condition); \
    > > if (unlikely(__ret_warn_on)) \
    > > if (__ratelimit(secs * HZ, 1)) \
    > > - WARN_ON(condition); \
    > > + WARN_ON(1); \
    > > + unlikely(__ret_warn_on); \
    > > })

    >
    > What's wrong with:
    >
    > #define WARN_ON_SECS(condition, secs) \
    > WARN_ON(condition && __ratelimit(secs * HZ, 1))


    Looks concise.
    Should I update the third time?
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [PATCH -mm] do not check condition twice in WARN_ON_SECS



    On Wed, 12 Mar 2008, Johannes Weiner wrote:
    >
    > What's wrong with:
    >
    > #define WARN_ON_SECS(condition, secs) \
    > WARN_ON(condition && __ratelimit(secs * HZ, 1))


    Add parenthesis around the arguments, please.

    Linus
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread