[PATCH 06/24] ide-tape: remove unused stage-parameter from idetape_copy_stage_to_user - Kernel

This is a discussion on [PATCH 06/24] ide-tape: remove unused stage-parameter from idetape_copy_stage_to_user - Kernel ; Signed-off-by: Borislav Petkov --- drivers/ide/ide-tape.c | 11 ++++------- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 6bca29b..a54c1cb 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c @@ -1717,7 +1717,7 @@ static int idetape_copy_stage_from_user(idetape_tape_t *tape, } static int idetape_copy_stage_to_user(idetape_tape_t *tape, char ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH 06/24] ide-tape: remove unused stage-parameter from idetape_copy_stage_to_user

  1. [PATCH 06/24] ide-tape: remove unused stage-parameter from idetape_copy_stage_to_user

    Signed-off-by: Borislav Petkov
    ---
    drivers/ide/ide-tape.c | 11 ++++-------
    1 files changed, 4 insertions(+), 7 deletions(-)

    diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
    index 6bca29b..a54c1cb 100644
    --- a/drivers/ide/ide-tape.c
    +++ b/drivers/ide/ide-tape.c
    @@ -1717,7 +1717,7 @@ static int idetape_copy_stage_from_user(idetape_tape_t *tape,
    }

    static int idetape_copy_stage_to_user(idetape_tape_t *tape, char __user *buf,
    - idetape_stage_t *stage, int n)
    + int n)
    {
    struct idetape_bh *bh = tape->bh;
    int count;
    @@ -2576,8 +2576,7 @@ static ssize_t idetape_chrdev_read(struct file *file, char __user *buf,
    if (tape->merge_stage_size) {
    actually_read = min((unsigned int)(tape->merge_stage_size),
    (unsigned int)count);
    - if (idetape_copy_stage_to_user(tape, buf, tape->merge_stage,
    - actually_read))
    + if (idetape_copy_stage_to_user(tape, buf, actually_read))
    ret = -EFAULT;
    buf += actually_read;
    tape->merge_stage_size -= actually_read;
    @@ -2587,8 +2586,7 @@ static ssize_t idetape_chrdev_read(struct file *file, char __user *buf,
    bytes_read = idetape_add_chrdev_read_request(drive, ctl);
    if (bytes_read <= 0)
    goto finish;
    - if (idetape_copy_stage_to_user(tape, buf, tape->merge_stage,
    - bytes_read))
    + if (idetape_copy_stage_to_user(tape, buf, bytes_read))
    ret = -EFAULT;
    buf += bytes_read;
    count -= bytes_read;
    @@ -2599,8 +2597,7 @@ static ssize_t idetape_chrdev_read(struct file *file, char __user *buf,
    if (bytes_read <= 0)
    goto finish;
    temp = min((unsigned long)count, (unsigned long)bytes_read);
    - if (idetape_copy_stage_to_user(tape, buf, tape->merge_stage,
    - temp))
    + if (idetape_copy_stage_to_user(tape, buf, temp))
    ret = -EFAULT;
    actually_read += temp;
    tape->merge_stage_size = bytes_read-temp;
    --
    1.5.4.1

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH 06/24] ide-tape: remove unused stage-parameter from idetape_copy_stage_to_user

    On Saturday 01 March 2008, Borislav Petkov wrote:
    > Signed-off-by: Borislav Petkov


    please move it at the beginning of the patch series

    Lets stop at this patch for now and get changes from patches #2-6
    into IDE tree first before moving on patches #7-24.

    Thanks,
    Bart
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread