[PATCH 2/2] nfsd: fix sparse warning in vfs.c - Kernel

This is a discussion on [PATCH 2/2] nfsd: fix sparse warning in vfs.c - Kernel ; fs/nfsd/vfs.c:991:27: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison --- fs/nfsd/vfs.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 0265310..17ac51b 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -988,7 +988,7 @@ nfsd_vfs_write(struct svc_rqst ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH 2/2] nfsd: fix sparse warning in vfs.c

  1. [PATCH 2/2] nfsd: fix sparse warning in vfs.c

    fs/nfsd/vfs.c:991:27: warning: Using plain integer as NULL pointer

    Signed-off-by: Harvey Harrison
    ---
    fs/nfsd/vfs.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
    index 0265310..17ac51b 100644
    --- a/fs/nfsd/vfs.c
    +++ b/fs/nfsd/vfs.c
    @@ -988,7 +988,7 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file,
    * flushing the data to disk is handled separately below.
    */

    - if (file->f_op->fsync == 0) {/* COMMIT3 cannot work */
    + if (!file->f_op->fsync) {/* COMMIT3 cannot work */
    stable = 2;
    *stablep = 2; /* FILE_SYNC */
    }
    --
    1.5.4.2.200.g99e75

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH 2/2] nfsd: fix sparse warning in vfs.c

    On Wed, Feb 20, 2008 at 12:49:02PM -0800, Harvey Harrison wrote:
    > fs/nfsd/vfs.c:991:27: warning: Using plain integer as NULL pointer
    >
    > Signed-off-by: Harvey Harrison
    > ---
    > fs/nfsd/vfs.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)


    Also applied, thanks.--b.

    >
    > diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
    > index 0265310..17ac51b 100644
    > --- a/fs/nfsd/vfs.c
    > +++ b/fs/nfsd/vfs.c
    > @@ -988,7 +988,7 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file,
    > * flushing the data to disk is handled separately below.
    > */
    >
    > - if (file->f_op->fsync == 0) {/* COMMIT3 cannot work */
    > + if (!file->f_op->fsync) {/* COMMIT3 cannot work */
    > stable = 2;
    > *stablep = 2; /* FILE_SYNC */
    > }
    > --
    > 1.5.4.2.200.g99e75
    >

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread