[PATCH] x86: make early_console static in early_printk.c - Kernel

This is a discussion on [PATCH] x86: make early_console static in early_printk.c - Kernel ; Not necessary to expose it, also fixes sparse warning. arch/x86/kernel/early_printk.c:196:16: warning: symbol 'early_console' was not declared. Should it be static? Signed-off-by: Harvey Harrison --- arch/x86/kernel/early_printk.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/early_printk.c b/arch/x86/kernel/early_printk.c index ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] x86: make early_console static in early_printk.c

  1. [PATCH] x86: make early_console static in early_printk.c

    Not necessary to expose it, also fixes sparse warning.

    arch/x86/kernel/early_printk.c:196:16: warning: symbol 'early_console' was not declared. Should it be static?

    Signed-off-by: Harvey Harrison
    ---
    arch/x86/kernel/early_printk.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/arch/x86/kernel/early_printk.c b/arch/x86/kernel/early_printk.c
    index b7d6c23..cff84cd 100644
    --- a/arch/x86/kernel/early_printk.c
    +++ b/arch/x86/kernel/early_printk.c
    @@ -193,7 +193,7 @@ static struct console simnow_console = {
    };

    /* Direct interface for emergencies */
    -struct console *early_console = &early_vga_console;
    +static struct console *early_console = &early_vga_console;
    static int early_console_initialized = 0;

    void early_printk(const char *fmt, ...)
    --
    1.5.4.rc4.1142.gf5a97



    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] x86: make early_console static in early_printk.c


    * Harvey Harrison wrote:

    > /* Direct interface for emergencies */
    > -struct console *early_console = &early_vga_console;
    > +static struct console *early_console = &early_vga_console;


    thanks, applied.

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread