[2.6 patch] e1000e/ethtool.c: make a function static - Kernel

This is a discussion on [2.6 patch] e1000e/ethtool.c: make a function static - Kernel ; This patch makes the needlessly global reg_pattern_test_array() static. Signed-off-by: Adrian Bunk --- ed72e457f06311390d9a9e51a00c904939466aff diff --git a/drivers/net/e1000e/ethtool.c b/drivers/net/e1000e/ethtool.c index 6d9c27f..a2034cf 100644 --- a/drivers/net/e1000e/ethtool.c +++ b/drivers/net/e1000e/ethtool.c @@ -690,8 +690,8 @@ err_setup: return err; } -bool reg_pattern_test_array(struct e1000_adapter *adapter, u64 *data, - int ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [2.6 patch] e1000e/ethtool.c: make a function static

  1. [2.6 patch] e1000e/ethtool.c: make a function static

    This patch makes the needlessly global reg_pattern_test_array() static.

    Signed-off-by: Adrian Bunk

    ---
    ed72e457f06311390d9a9e51a00c904939466aff
    diff --git a/drivers/net/e1000e/ethtool.c b/drivers/net/e1000e/ethtool.c
    index 6d9c27f..a2034cf 100644
    --- a/drivers/net/e1000e/ethtool.c
    +++ b/drivers/net/e1000e/ethtool.c
    @@ -690,8 +690,8 @@ err_setup:
    return err;
    }

    -bool reg_pattern_test_array(struct e1000_adapter *adapter, u64 *data,
    - int reg, int offset, u32 mask, u32 write)
    +static bool reg_pattern_test_array(struct e1000_adapter *adapter, u64 *data,
    + int reg, int offset, u32 mask, u32 write)
    {
    int i;
    u32 read;

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [2.6 patch] e1000e/ethtool.c: make a function static

    Adrian Bunk wrote:
    > This patch makes the needlessly global reg_pattern_test_array() static.
    >
    > Signed-off-by: Adrian Bunk


    stephen hemminger already pointed this out to me... I'll certainly push this
    upstream, thanks Adrian!

    Auke


    >
    > ---
    > ed72e457f06311390d9a9e51a00c904939466aff
    > diff --git a/drivers/net/e1000e/ethtool.c b/drivers/net/e1000e/ethtool.c
    > index 6d9c27f..a2034cf 100644
    > --- a/drivers/net/e1000e/ethtool.c
    > +++ b/drivers/net/e1000e/ethtool.c
    > @@ -690,8 +690,8 @@ err_setup:
    > return err;
    > }
    >
    > -bool reg_pattern_test_array(struct e1000_adapter *adapter, u64 *data,
    > - int reg, int offset, u32 mask, u32 write)
    > +static bool reg_pattern_test_array(struct e1000_adapter *adapter, u64 *data,
    > + int reg, int offset, u32 mask, u32 write)
    > {
    > int i;
    > u32 read;
    >


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread