[BUG] x86: duplicated TIF number - Kernel

This is a discussion on [BUG] x86: duplicated TIF number - Kernel ; Hi, I wonder if this is expected ? (in current 2.6.24-git) commit 7e9916040b3020d0f36d68bb7512e3b80b623097 and commit eee3af4a2c83a97fff107ddc445d9df6fded9ce4 Both use the same TIF number (25) in thread_info_64.h. Mathieu -- Mathieu Desnoyers Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal OpenPGP key fingerprint: ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: [BUG] x86: duplicated TIF number

  1. [BUG] x86: duplicated TIF number

    Hi,

    I wonder if this is expected ? (in current 2.6.24-git)

    commit 7e9916040b3020d0f36d68bb7512e3b80b623097
    and commit eee3af4a2c83a97fff107ddc445d9df6fded9ce4

    Both use the same TIF number (25) in thread_info_64.h.

    Mathieu


    --
    Mathieu Desnoyers
    Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
    OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. [PATCH] Fix x86_64 duplicated TIF

    I wonder if this is expected ? (in current 2.6.24-git)

    commit 7e9916040b3020d0f36d68bb7512e3b80b623097
    and commit eee3af4a2c83a97fff107ddc445d9df6fded9ce4

    Both use the same TIF number (25) in thread_info_64.h.

    This patch changes the TIF ids.

    Signed-off-by: Mathieu Desnoyers
    ---
    include/asm-x86/thread_info_64.h | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    Index: linux-2.6-lttng/include/asm-x86/thread_info_64.h
    ================================================== =================
    --- linux-2.6-lttng.orig/include/asm-x86/thread_info_64.h 2008-01-30 09:52:56.000000000 -0500
    +++ linux-2.6-lttng/include/asm-x86/thread_info_64.h 2008-01-30 09:53:14.000000000 -0500
    @@ -123,8 +123,8 @@ static inline struct thread_info *stack_
    #define TIF_FREEZE 23 /* is freezing for suspend */
    #define TIF_FORCED_TF 24 /* true if TF in eflags artificially */
    #define TIF_DEBUGCTLMSR 25 /* uses thread_struct.debugctlmsr */
    -#define TIF_DS_AREA_MSR 25 /* uses thread_struct.ds_area_msr */
    -#define TIF_BTS_TRACE_TS 26 /* record scheduling event timestamps */
    +#define TIF_DS_AREA_MSR 26 /* uses thread_struct.ds_area_msr */
    +#define TIF_BTS_TRACE_TS 27 /* record scheduling event timestamps */

    #define _TIF_SYSCALL_TRACE (1< #define _TIF_SIGPENDING (1<
    --
    Mathieu Desnoyers
    Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
    OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] Fix x86_64 duplicated TIF


    * Mathieu Desnoyers wrote:

    > I wonder if this is expected ? (in current 2.6.24-git)
    >
    > commit 7e9916040b3020d0f36d68bb7512e3b80b623097
    > and commit eee3af4a2c83a97fff107ddc445d9df6fded9ce4
    >
    > Both use the same TIF number (25) in thread_info_64.h.


    > #define TIF_DEBUGCTLMSR 25 /* uses thread_struct.debugctlmsr */
    > -#define TIF_DS_AREA_MSR 25 /* uses thread_struct.ds_area_msr */
    > -#define TIF_BTS_TRACE_TS 26 /* record scheduling event timestamps */
    > +#define TIF_DS_AREA_MSR 26 /* uses thread_struct.ds_area_msr */
    > +#define TIF_BTS_TRACE_TS 27 /* record scheduling event timestamps */


    thanks, applied.

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread