Re: [WARNING -rc8] at fs/sysfs/dir.c:424 sysfs_add_one(), related with processor (ACPI) - Kernel

This is a discussion on Re: [WARNING -rc8] at fs/sysfs/dir.c:424 sysfs_add_one(), related with processor (ACPI) - Kernel ; > On Mon, 21 Jan 2008 18:53:18 +0100 "Miguel Ojeda" wrote: > Booting 2.6.24-rc8 I get this: > > > sysfs: duplicate filename 'fan' can not be created > WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() > Pid: 819, comm: modprobe Not tainted ...

+ Reply to Thread
Results 1 to 5 of 5

Thread: Re: [WARNING -rc8] at fs/sysfs/dir.c:424 sysfs_add_one(), related with processor (ACPI)

  1. Re: [WARNING -rc8] at fs/sysfs/dir.c:424 sysfs_add_one(), related with processor (ACPI)

    > On Mon, 21 Jan 2008 18:53:18 +0100 "Miguel Ojeda" wrote:
    > Booting 2.6.24-rc8 I get this:
    >
    >
    > sysfs: duplicate filename 'fan' can not be created
    > WARNING: at fs/sysfs/dir.c:424 sysfs_add_one()
    > Pid: 819, comm: modprobe Not tainted 2.6.24-rc8 #2
    > [] sysfs_add_one+0x9f/0xe0
    > [] create_dir+0x48/0x90
    > [] sysfs_create_dir+0x29/0x50
    > [] kobject_get+0xf/0x20
    > [] kobject_add+0x8f/0x1b0
    > [] kobject_register+0x21/0x50
    > [] bus_add_driver+0x71/0x1e0
    > [] acpi_fan_init+0x2f/0x4d [fan]
    > [] sys_init_module+0x126/0x19b0
    > [] rb_insert_color+0xb7/0xe0
    > [] acpi_bus_register_driver+0x0/0x38
    > [] syscall_call+0x7/0xb
    > =======================
    > kobject_add failed for fan with -EEXIST, don't try to register things
    > with the same name in the same directory.
    > Pid: 819, comm: modprobe Not tainted 2.6.24-rc8 #2
    > [] kobject_add+0x111/0x1b0
    > [] kobject_register+0x21/0x50
    > [] bus_add_driver+0x71/0x1e0
    > [] acpi_fan_init+0x2f/0x4d [fan]
    > [] sys_init_module+0x126/0x19b0
    > [] rb_insert_color+0xb7/0xe0
    > [] acpi_bus_register_driver+0x0/0x38
    > [] syscall_call+0x7/0xb
    > =======================
    > processor: exports duplicate symbol acpi_processor_set_thermal_limit
    > (owned by kernel)
    >
    >
    >
    > After that, there are five more traces. Attached dmesg output and .config.
    >


    Cc linux-acpi. If nothing happens (not uncommon) then please raise a
    report agaisnt acpi at bugzilla.kernel.org, thanks.

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [WARNING -rc8] at fs/sysfs/dir.c:424 sysfs_add_one(), related with processor (ACPI)

    On Wed, Jan 23, 2008 at 02:06:43PM -0800, Andrew Morton wrote:
    > > On Mon, 21 Jan 2008 18:53:18 +0100 "Miguel Ojeda" wrote:
    > > Booting 2.6.24-rc8 I get this:
    > >
    > >
    > > sysfs: duplicate filename 'fan' can not be created
    > > WARNING: at fs/sysfs/dir.c:424 sysfs_add_one()
    > > Pid: 819, comm: modprobe Not tainted 2.6.24-rc8 #2
    > > [] sysfs_add_one+0x9f/0xe0
    > > [] create_dir+0x48/0x90
    > > [] sysfs_create_dir+0x29/0x50
    > > [] kobject_get+0xf/0x20
    > > [] kobject_add+0x8f/0x1b0
    > > [] kobject_register+0x21/0x50
    > > [] bus_add_driver+0x71/0x1e0
    > > [] acpi_fan_init+0x2f/0x4d [fan]
    > > [] sys_init_module+0x126/0x19b0
    > > [] rb_insert_color+0xb7/0xe0
    > > [] acpi_bus_register_driver+0x0/0x38
    > > [] syscall_call+0x7/0xb
    > > =======================
    > > kobject_add failed for fan with -EEXIST, don't try to register things
    > > with the same name in the same directory.
    > > Pid: 819, comm: modprobe Not tainted 2.6.24-rc8 #2
    > > [] kobject_add+0x111/0x1b0
    > > [] kobject_register+0x21/0x50
    > > [] bus_add_driver+0x71/0x1e0
    > > [] acpi_fan_init+0x2f/0x4d [fan]
    > > [] sys_init_module+0x126/0x19b0
    > > [] rb_insert_color+0xb7/0xe0
    > > [] acpi_bus_register_driver+0x0/0x38
    > > [] syscall_call+0x7/0xb
    > > =======================
    > > processor: exports duplicate symbol acpi_processor_set_thermal_limit
    > > (owned by kernel)
    > >


    Could apply following debug patch and see the result?


    diff -upr linux/fs/sysfs/dir.c linux.new/fs/sysfs/dir.c
    --- linux/fs/sysfs/dir.c 2008-01-23 09:56:24.000000000 +0800
    +++ linux.new/fs/sysfs/dir.c 2008-01-23 09:59:12.000000000 +0800
    @@ -418,6 +418,8 @@ void sysfs_addrm_start(struct sysfs_addr
    */
    int sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd)
    {
    + if (!strcmp(sd->s_name, "fan"))
    + dump_stack();
    if (sysfs_find_dirent(acxt->parent_sd, sd->s_name)) {
    printk(KERN_WARNING "sysfs: duplicate filename '%s' "
    "can not be created\n", sd->s_name);

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [WARNING -rc8] at fs/sysfs/dir.c:424 sysfs_add_one(), related with processor (ACPI)

    On Jan 25, 2008 12:32 AM, Miguel Ojeda wrote:
    >
    > On Jan 24, 2008 2:44 AM, Dave Young wrote:
    > >
    > > On Wed, Jan 23, 2008 at 02:06:43PM -0800, Andrew Morton wrote:
    > > > > On Mon, 21 Jan 2008 18:53:18 +0100 "Miguel Ojeda" wrote:
    > > > > Booting 2.6.24-rc8 I get this:
    > > > >
    > > > >
    > > > > sysfs: duplicate filename 'fan' can not be created
    > > > > WARNING: at fs/sysfs/dir.c:424 sysfs_add_one()
    > > > > Pid: 819, comm: modprobe Not tainted 2.6.24-rc8 #2
    > > > > [] sysfs_add_one+0x9f/0xe0
    > > > > [] create_dir+0x48/0x90
    > > > > [] sysfs_create_dir+0x29/0x50
    > > > > [] kobject_get+0xf/0x20
    > > > > [] kobject_add+0x8f/0x1b0
    > > > > [] kobject_register+0x21/0x50
    > > > > [] bus_add_driver+0x71/0x1e0
    > > > > [] acpi_fan_init+0x2f/0x4d [fan]
    > > > > [] sys_init_module+0x126/0x19b0
    > > > > [] rb_insert_color+0xb7/0xe0
    > > > > [] acpi_bus_register_driver+0x0/0x38
    > > > > [] syscall_call+0x7/0xb
    > > > > =======================
    > > > > kobject_add failed for fan with -EEXIST, don't try to register things
    > > > > with the same name in the same directory.
    > > > > Pid: 819, comm: modprobe Not tainted 2.6.24-rc8 #2
    > > > > [] kobject_add+0x111/0x1b0
    > > > > [] kobject_register+0x21/0x50
    > > > > [] bus_add_driver+0x71/0x1e0
    > > > > [] acpi_fan_init+0x2f/0x4d [fan]
    > > > > [] sys_init_module+0x126/0x19b0
    > > > > [] rb_insert_color+0xb7/0xe0
    > > > > [] acpi_bus_register_driver+0x0/0x38
    > > > > [] syscall_call+0x7/0xb
    > > > > =======================
    > > > > processor: exports duplicate symbol acpi_processor_set_thermal_limit
    > > > > (owned by kernel)
    > > > >

    > >
    > > Could apply following debug patch and see the result?
    > >
    > >
    > > diff -upr linux/fs/sysfs/dir.c linux.new/fs/sysfs/dir.c
    > > --- linux/fs/sysfs/dir.c 2008-01-23 09:56:24.000000000 +0800
    > > +++ linux.new/fs/sysfs/dir.c 2008-01-23 09:59:12.000000000 +0800
    > > @@ -418,6 +418,8 @@ void sysfs_addrm_start(struct sysfs_addr
    > > */
    > > int sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd)
    > > {
    > > + if (!strcmp(sd->s_name, "fan"))
    > > + dump_stack();
    > > if (sysfs_find_dirent(acxt->parent_sd, sd->s_name)) {
    > > printk(KERN_WARNING "sysfs: duplicate filename '%s' "
    > > "can not be created\n", sd->s_name);
    > >
    > >

    >
    > Done. The following appears in the new dmesg output.
    >
    >
    > ACPI: Power Button (CM) [PBTN]
    > input: Sleep Button (CM) as /class/input/input2
    > ACPI: Sleep Button (CM) [SBTN]
    > Pid: 1, comm: swapper Not tainted 2.6.24-rc8 #3
    > [] sysfs_add_one+0x75/0x100
    > [] sysfs_addrm_start+0x3f/0xb0
    > [] create_dir+0x48/0x90
    > [] sysfs_create_dir+0x29/0x50
    > [] kobject_get+0xf/0x20
    > [] kobject_add+0x8f/0x1b0
    > [] kobject_register+0x21/0x50
    > [] bus_add_driver+0x71/0x1e0
    > [] acpi_fan_init+0x2f/0x4d
    > [] kernel_init+0x121/0x300
    > [] ret_from_fork+0x6/0x1c
    > [] kernel_init+0x0/0x300
    > [] kernel_init+0x0/0x300
    > [] kernel_thread_helper+0x7/0x18
    > =======================


    I'm curious, the "fan" is configured as built-in, why the modprobe be called?

    > ACPI: SSDT 3FE93134, 0244 (r1 PmRef Cpu0Ist 3000 INTL 20050624)
    > ACPI: SSDT 3FE92ACA, 05E5 (r1 PmRef Cpu0Cst 3001 INTL 20050624)
    > Monitor-Mwait will be used to enter C-1 state
    > Monitor-Mwait will be used to enter C-2 state
    >
    > Attached dmesg.txt
    >
    >
    > --
    > Miguel Ojeda
    > http://maxextreme.googlepages.com/index.htm
    >

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [WARNING -rc8] at fs/sysfs/dir.c:424 sysfs_add_one(), related with processor (ACPI)

    On Jan 25, 2008 9:27 AM, Dave Young wrote:
    >
    > On Jan 25, 2008 12:32 AM, Miguel Ojeda wrote:
    > >
    > > On Jan 24, 2008 2:44 AM, Dave Young wrote:
    > > >
    > > > On Wed, Jan 23, 2008 at 02:06:43PM -0800, Andrew Morton wrote:
    > > > > > On Mon, 21 Jan 2008 18:53:18 +0100 "Miguel Ojeda" wrote:
    > > > > > Booting 2.6.24-rc8 I get this:
    > > > > >
    > > > > >
    > > > > > sysfs: duplicate filename 'fan' can not be created
    > > > > > WARNING: at fs/sysfs/dir.c:424 sysfs_add_one()
    > > > > > Pid: 819, comm: modprobe Not tainted 2.6.24-rc8 #2
    > > > > > [] sysfs_add_one+0x9f/0xe0
    > > > > > [] create_dir+0x48/0x90
    > > > > > [] sysfs_create_dir+0x29/0x50
    > > > > > [] kobject_get+0xf/0x20
    > > > > > [] kobject_add+0x8f/0x1b0
    > > > > > [] kobject_register+0x21/0x50
    > > > > > [] bus_add_driver+0x71/0x1e0
    > > > > > [] acpi_fan_init+0x2f/0x4d [fan]
    > > > > > [] sys_init_module+0x126/0x19b0
    > > > > > [] rb_insert_color+0xb7/0xe0
    > > > > > [] acpi_bus_register_driver+0x0/0x38
    > > > > > [] syscall_call+0x7/0xb
    > > > > > =======================
    > > > > > kobject_add failed for fan with -EEXIST, don't try to register things
    > > > > > with the same name in the same directory.
    > > > > > Pid: 819, comm: modprobe Not tainted 2.6.24-rc8 #2
    > > > > > [] kobject_add+0x111/0x1b0
    > > > > > [] kobject_register+0x21/0x50
    > > > > > [] bus_add_driver+0x71/0x1e0
    > > > > > [] acpi_fan_init+0x2f/0x4d [fan]
    > > > > > [] sys_init_module+0x126/0x19b0
    > > > > > [] rb_insert_color+0xb7/0xe0
    > > > > > [] acpi_bus_register_driver+0x0/0x38
    > > > > > [] syscall_call+0x7/0xb
    > > > > > =======================
    > > > > > processor: exports duplicate symbol acpi_processor_set_thermal_limit
    > > > > > (owned by kernel)
    > > > > >
    > > >
    > > > Could apply following debug patch and see the result?
    > > >
    > > >
    > > > diff -upr linux/fs/sysfs/dir.c linux.new/fs/sysfs/dir.c
    > > > --- linux/fs/sysfs/dir.c 2008-01-23 09:56:24.000000000 +0800
    > > > +++ linux.new/fs/sysfs/dir.c 2008-01-23 09:59:12.000000000 +0800
    > > > @@ -418,6 +418,8 @@ void sysfs_addrm_start(struct sysfs_addr
    > > > */
    > > > int sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd)
    > > > {
    > > > + if (!strcmp(sd->s_name, "fan"))
    > > > + dump_stack();
    > > > if (sysfs_find_dirent(acxt->parent_sd, sd->s_name)) {
    > > > printk(KERN_WARNING "sysfs: duplicate filename '%s' "
    > > > "can not be created\n", sd->s_name);
    > > >
    > > >

    > >
    > > Done. The following appears in the new dmesg output.
    > >
    > >
    > > ACPI: Power Button (CM) [PBTN]
    > > input: Sleep Button (CM) as /class/input/input2
    > > ACPI: Sleep Button (CM) [SBTN]
    > > Pid: 1, comm: swapper Not tainted 2.6.24-rc8 #3
    > > [] sysfs_add_one+0x75/0x100
    > > [] sysfs_addrm_start+0x3f/0xb0
    > > [] create_dir+0x48/0x90
    > > [] sysfs_create_dir+0x29/0x50
    > > [] kobject_get+0xf/0x20
    > > [] kobject_add+0x8f/0x1b0
    > > [] kobject_register+0x21/0x50
    > > [] bus_add_driver+0x71/0x1e0
    > > [] acpi_fan_init+0x2f/0x4d
    > > [] kernel_init+0x121/0x300
    > > [] ret_from_fork+0x6/0x1c
    > > [] kernel_init+0x0/0x300
    > > [] kernel_init+0x0/0x300
    > > [] kernel_thread_helper+0x7/0x18
    > > =======================

    >
    > I'm curious, the "fan" is configured as built-in, why the modprobe be called?


    I guess initrd or your lib/modules need update.

    >
    >
    > > ACPI: SSDT 3FE93134, 0244 (r1 PmRef Cpu0Ist 3000 INTL 20050624)
    > > ACPI: SSDT 3FE92ACA, 05E5 (r1 PmRef Cpu0Cst 3001 INTL 20050624)
    > > Monitor-Mwait will be used to enter C-1 state
    > > Monitor-Mwait will be used to enter C-2 state
    > >
    > > Attached dmesg.txt
    > >
    > >
    > > --
    > > Miguel Ojeda
    > > http://maxextreme.googlepages.com/index.htm
    > >

    >

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. Re: [WARNING -rc8] at fs/sysfs/dir.c:424 sysfs_add_one(), related with processor (ACPI)

    On Jan 30, 2008 6:48 AM, Dave Young wrote:
    >
    > On Jan 25, 2008 9:27 AM, Dave Young wrote:
    > >
    > > On Jan 25, 2008 12:32 AM, Miguel Ojeda wrote:
    > > >
    > > > On Jan 24, 2008 2:44 AM, Dave Young wrote:
    > > > >
    > > > > On Wed, Jan 23, 2008 at 02:06:43PM -0800, Andrew Morton wrote:
    > > > > > > On Mon, 21 Jan 2008 18:53:18 +0100 "Miguel Ojeda" wrote:
    > > > > > > Booting 2.6.24-rc8 I get this:
    > > > > > >
    > > > > > >
    > > > > > > sysfs: duplicate filename 'fan' can not be created
    > > > > > > WARNING: at fs/sysfs/dir.c:424 sysfs_add_one()
    > > > > > > Pid: 819, comm: modprobe Not tainted 2.6.24-rc8 #2
    > > > > > > [] sysfs_add_one+0x9f/0xe0
    > > > > > > [] create_dir+0x48/0x90
    > > > > > > [] sysfs_create_dir+0x29/0x50
    > > > > > > [] kobject_get+0xf/0x20
    > > > > > > [] kobject_add+0x8f/0x1b0
    > > > > > > [] kobject_register+0x21/0x50
    > > > > > > [] bus_add_driver+0x71/0x1e0
    > > > > > > [] acpi_fan_init+0x2f/0x4d [fan]
    > > > > > > [] sys_init_module+0x126/0x19b0
    > > > > > > [] rb_insert_color+0xb7/0xe0
    > > > > > > [] acpi_bus_register_driver+0x0/0x38
    > > > > > > [] syscall_call+0x7/0xb
    > > > > > > =======================
    > > > > > > kobject_add failed for fan with -EEXIST, don't try to register things
    > > > > > > with the same name in the same directory.
    > > > > > > Pid: 819, comm: modprobe Not tainted 2.6.24-rc8 #2
    > > > > > > [] kobject_add+0x111/0x1b0
    > > > > > > [] kobject_register+0x21/0x50
    > > > > > > [] bus_add_driver+0x71/0x1e0
    > > > > > > [] acpi_fan_init+0x2f/0x4d [fan]
    > > > > > > [] sys_init_module+0x126/0x19b0
    > > > > > > [] rb_insert_color+0xb7/0xe0
    > > > > > > [] acpi_bus_register_driver+0x0/0x38
    > > > > > > [] syscall_call+0x7/0xb
    > > > > > > =======================
    > > > > > > processor: exports duplicate symbol acpi_processor_set_thermal_limit
    > > > > > > (owned by kernel)
    > > > > > >
    > > > >
    > > > > Could apply following debug patch and see the result?
    > > > >
    > > > >
    > > > > diff -upr linux/fs/sysfs/dir.c linux.new/fs/sysfs/dir.c
    > > > > --- linux/fs/sysfs/dir.c 2008-01-23 09:56:24.000000000 +0800
    > > > > +++ linux.new/fs/sysfs/dir.c 2008-01-23 09:59:12.000000000 +0800
    > > > > @@ -418,6 +418,8 @@ void sysfs_addrm_start(struct sysfs_addr
    > > > > */
    > > > > int sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd)
    > > > > {
    > > > > + if (!strcmp(sd->s_name, "fan"))
    > > > > + dump_stack();
    > > > > if (sysfs_find_dirent(acxt->parent_sd, sd->s_name)) {
    > > > > printk(KERN_WARNING "sysfs: duplicate filename '%s' "
    > > > > "can not be created\n", sd->s_name);
    > > > >
    > > > >
    > > >
    > > > Done. The following appears in the new dmesg output.
    > > >
    > > >
    > > > ACPI: Power Button (CM) [PBTN]
    > > > input: Sleep Button (CM) as /class/input/input2
    > > > ACPI: Sleep Button (CM) [SBTN]
    > > > Pid: 1, comm: swapper Not tainted 2.6.24-rc8 #3
    > > > [] sysfs_add_one+0x75/0x100
    > > > [] sysfs_addrm_start+0x3f/0xb0
    > > > [] create_dir+0x48/0x90
    > > > [] sysfs_create_dir+0x29/0x50
    > > > [] kobject_get+0xf/0x20
    > > > [] kobject_add+0x8f/0x1b0
    > > > [] kobject_register+0x21/0x50
    > > > [] bus_add_driver+0x71/0x1e0
    > > > [] acpi_fan_init+0x2f/0x4d
    > > > [] kernel_init+0x121/0x300
    > > > [] ret_from_fork+0x6/0x1c
    > > > [] kernel_init+0x0/0x300
    > > > [] kernel_init+0x0/0x300
    > > > [] kernel_thread_helper+0x7/0x18
    > > > =======================

    > >
    > > I'm curious, the "fan" is configured as built-in, why the modprobe be called?

    >
    > I guess initrd or your lib/modules need update.
    >


    I haven't got any more of those WARN_ON's on 2.6.24, so I suppose it was fixed.

    --
    Miguel Ojeda
    http://maxextreme.googlepages.com/index.htm
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread