[PATCH 1/4] introduce __cpuinitconst - Kernel

This is a discussion on [PATCH 1/4] introduce __cpuinitconst - Kernel ; The patch doesn't change all instances where 'const' could have been added as a result of the base structure changes, only where the change has a real effect (the module loader doesn't enforce read-only section attributes at present, so only ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: [PATCH 1/4] introduce __cpuinitconst

  1. [PATCH 1/4] introduce __cpuinitconst

    The patch doesn't change all instances where 'const' could have been
    added as a result of the base structure changes, only where the change
    has a real effect (the module loader doesn't enforce read-only section
    attributes at present, so only built-in files make a real difference).

    Signed-off-by: Jan Beulich
    Cc: Len Brown
    Cc: Andi Kleen

    ---
    drivers/acpi/processor_idle.c | 2 +-
    include/linux/init.h | 2 ++
    2 files changed, 3 insertions(+), 1 deletion(-)

    --- 2.6.24-rc7-initconst.orig/drivers/acpi/processor_idle.c
    +++ 2.6.24-rc7-initconst/drivers/acpi/processor_idle.c
    @@ -118,7 +118,7 @@ static int set_max_cstate(const struct d

    /* Actually this shouldn't be __cpuinitdata, would be better to fix the
    callers to only run once -AK */
    -static struct dmi_system_id __cpuinitdata processor_power_dmi_table[] = {
    +static struct dmi_system_id __cpuinitconst processor_power_dmi_table[] = {
    { set_max_cstate, "IBM ThinkPad R40e", {
    DMI_MATCH(DMI_BIOS_VENDOR,"IBM"),
    DMI_MATCH(DMI_BIOS_VERSION,"1SET70WW")}, (void *)1},
    --- 2.6.24-rc7-initconst.orig/include/linux/init.h
    +++ 2.6.24-rc7-initconst/include/linux/init.h
    @@ -269,11 +269,13 @@ void __init parse_early_param(void);
    #ifdef CONFIG_HOTPLUG_CPU
    #define __cpuinit
    #define __cpuinitdata
    +#define __cpuinitconst const
    #define __cpuexit
    #define __cpuexitdata
    #else
    #define __cpuinit __init
    #define __cpuinitdata __initdata
    +#define __cpuinitconst __initdata
    #define __cpuexit __exit
    #define __cpuexitdata __exitdata
    #endif



    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH 1/4] introduce __cpuinitconst

    On Fri, Jan 11, 2008 at 08:56:16AM +0000, Jan Beulich wrote:
    > The patch doesn't change all instances where 'const' could have been
    > added as a result of the base structure changes, only where the change
    > has a real effect (the module loader doesn't enforce read-only section
    > attributes at present, so only built-in files make a real difference).
    >
    > Signed-off-by: Jan Beulich
    > Cc: Len Brown
    > Cc: Andi Kleen
    >
    > ---
    > drivers/acpi/processor_idle.c | 2 +-
    > include/linux/init.h | 2 ++
    > 2 files changed, 3 insertions(+), 1 deletion(-)
    >
    > --- 2.6.24-rc7-initconst.orig/drivers/acpi/processor_idle.c
    > +++ 2.6.24-rc7-initconst/drivers/acpi/processor_idle.c
    > @@ -118,7 +118,7 @@ static int set_max_cstate(const struct d
    >
    > /* Actually this shouldn't be __cpuinitdata, would be better to fix the
    > callers to only run once -AK */
    > -static struct dmi_system_id __cpuinitdata processor_power_dmi_table[] = {
    > +static struct dmi_system_id __cpuinitconst processor_power_dmi_table[] = {
    > { set_max_cstate, "IBM ThinkPad R40e", {
    > DMI_MATCH(DMI_BIOS_VENDOR,"IBM"),
    > DMI_MATCH(DMI_BIOS_VERSION,"1SET70WW")}, (void *)1},
    > --- 2.6.24-rc7-initconst.orig/include/linux/init.h
    > +++ 2.6.24-rc7-initconst/include/linux/init.h
    > @@ -269,11 +269,13 @@ void __init parse_early_param(void);
    > #ifdef CONFIG_HOTPLUG_CPU
    > #define __cpuinit
    > #define __cpuinitdata
    > +#define __cpuinitconst const
    > #define __cpuexit
    > #define __cpuexitdata
    > #else
    > #define __cpuinit __init
    > #define __cpuinitdata __initdata
    > +#define __cpuinitconst __initdata
    > #define __cpuexit __exit
    > #define __cpuexitdata __exitdata
    > #endif


    __cpuinitconstdata ?

    I know it's a bit long, but it would be more logically when looking at
    the other ones.

    cu
    Adrian

    --

    "Is there not promise of rain?" Ling Tan asked suddenly out
    of the darkness. There had been need of rain for many days.
    "Only a promise," Lao Er said.
    Pearl S. Buck - Dragon Seed

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH 1/4] introduce __cpuinitconst

    >> --- 2.6.24-rc7-initconst.orig/include/linux/init.h
    >> +++ 2.6.24-rc7-initconst/include/linux/init.h
    >> @@ -269,11 +269,13 @@ void __init parse_early_param(void);
    >> #ifdef CONFIG_HOTPLUG_CPU
    >> #define __cpuinit
    >> #define __cpuinitdata
    >> +#define __cpuinitconst const
    >> #define __cpuexit
    >> #define __cpuexitdata
    >> #else
    >> #define __cpuinit __init
    >> #define __cpuinitdata __initdata
    >> +#define __cpuinitconst __initdata
    >> #define __cpuexit __exit
    >> #define __cpuexitdata __exitdata
    >> #endif

    >
    >__cpuinitconstdata ?
    >
    >I know it's a bit long, but it would be more logically when looking at
    >the other ones.


    I considered it, but didn't use it because as you say it's a bit long and
    additionally nothing but data can be 'const'.

    Jan

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread