Re: [2.6.24-rc6-mm1] Build Failure on ppc64 with CONFIG_USB_GADGET not set. - Kernel

This is a discussion on Re: [2.6.24-rc6-mm1] Build Failure on ppc64 with CONFIG_USB_GADGET not set. - Kernel ; On Mon, 7 Jan 2008 16:53:58 +0530 "sudhir kumar" wrote: > Hi Andrew! > > Kernel build fails on my ppc64 machine. It seems to be a dependency > problem with CONFIG_USB_GADGET not set. > Config file is attached. > ...

+ Reply to Thread
Results 1 to 4 of 4

Thread: Re: [2.6.24-rc6-mm1] Build Failure on ppc64 with CONFIG_USB_GADGET not set.

  1. Re: [2.6.24-rc6-mm1] Build Failure on ppc64 with CONFIG_USB_GADGET not set.

    On Mon, 7 Jan 2008 16:53:58 +0530 "sudhir kumar" wrote:

    > Hi Andrew!
    >
    > Kernel build fails on my ppc64 machine. It seems to be a dependency
    > problem with CONFIG_USB_GADGET not set.
    > Config file is attached.
    >
    > CC init/version.o
    > LD init/built-in.o
    > LD .tmp_vmlinux1
    > drivers/built-in.o: In function `oz99x_remove':
    > drivers/i2c/chips/oz99x.c:660: undefined reference to `.led_classdev_unregister'
    > drivers/built-in.o: In function `oz99x_configure_leds':
    > drivers/i2c/chips/oz99x.c:314: undefined reference to `.led_classdev_register'
    > make: *** [.tmp_vmlinux1] Error 1
    >


    Strange.

    oz99x-i2c-button-and-led-support-driver.patch has

    +config OZ99X
    + tristate "O2 Micro/ETC OZ990/OZ992 SMBus chip"
    + depends on I2C
    + select INPUT_POLLDEV
    + select LEDS_CLASS

    and your .config gives

    box:/usr/src/25> grep LEDS .config
    # CONFIG_NEW_LEDS is not set
    CONFIG_LEDS_CLASS=y

    so drivers/leds/led-class.o should be linked into your vmlinux. But that
    obviously isn't happening.

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [2.6.24-rc6-mm1] Build Failure on ppc64 with CONFIG_USB_GADGET not set.

    On Mon, Jan 07, 2008 at 09:49:55AM -0800, Andrew Morton wrote:
    > On Mon, 7 Jan 2008 16:53:58 +0530 "sudhir kumar" wrote:
    >
    > > Hi Andrew!
    > >
    > > Kernel build fails on my ppc64 machine. It seems to be a dependency
    > > problem with CONFIG_USB_GADGET not set.
    > > Config file is attached.
    > >
    > > CC init/version.o
    > > LD init/built-in.o
    > > LD .tmp_vmlinux1
    > > drivers/built-in.o: In function `oz99x_remove':
    > > drivers/i2c/chips/oz99x.c:660: undefined reference to `.led_classdev_unregister'
    > > drivers/built-in.o: In function `oz99x_configure_leds':
    > > drivers/i2c/chips/oz99x.c:314: undefined reference to `.led_classdev_register'
    > > make: *** [.tmp_vmlinux1] Error 1
    > >

    >
    > Strange.
    >
    > oz99x-i2c-button-and-led-support-driver.patch has
    >
    > +config OZ99X
    > + tristate "O2 Micro/ETC OZ990/OZ992 SMBus chip"
    > + depends on I2C
    > + select INPUT_POLLDEV
    > + select LEDS_CLASS
    >
    > and your .config gives
    >
    > box:/usr/src/25> grep LEDS .config
    > # CONFIG_NEW_LEDS is not set
    > CONFIG_LEDS_CLASS=y
    >
    > so drivers/leds/led-class.o should be linked into your vmlinux. But that
    > obviously isn't happening.

    Because CONFIG_NEW_LEDS is not set we do not visit drivers/leds due to:
    obj-$(CONFIG_NEW_LEDS) += leds/
    in drivers/Makefile

    This is evil select playing games (again).
    We have LEDS_CLASS equal y but NEW_LEDS equal n

    Sam
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [2.6.24-rc6-mm1] Build Failure on ppc64 with CONFIG_USB_GADGET not set.

    On Mon, 7 Jan 2008 20:15:31 +0100
    Sam Ravnborg wrote:

    > On Mon, Jan 07, 2008 at 09:49:55AM -0800, Andrew Morton wrote:
    > > On Mon, 7 Jan 2008 16:53:58 +0530 "sudhir kumar" wrote:
    > >
    > > > Hi Andrew!
    > > >
    > > > Kernel build fails on my ppc64 machine. It seems to be a dependency
    > > > problem with CONFIG_USB_GADGET not set.
    > > > Config file is attached.
    > > >
    > > > CC init/version.o
    > > > LD init/built-in.o
    > > > LD .tmp_vmlinux1
    > > > drivers/built-in.o: In function `oz99x_remove':
    > > > drivers/i2c/chips/oz99x.c:660: undefined reference to `.led_classdev_unregister'
    > > > drivers/built-in.o: In function `oz99x_configure_leds':
    > > > drivers/i2c/chips/oz99x.c:314: undefined reference to `.led_classdev_register'
    > > > make: *** [.tmp_vmlinux1] Error 1
    > > >

    > >
    > > Strange.
    > >
    > > oz99x-i2c-button-and-led-support-driver.patch has
    > >
    > > +config OZ99X
    > > + tristate "O2 Micro/ETC OZ990/OZ992 SMBus chip"
    > > + depends on I2C
    > > + select INPUT_POLLDEV
    > > + select LEDS_CLASS
    > >
    > > and your .config gives
    > >
    > > box:/usr/src/25> grep LEDS .config
    > > # CONFIG_NEW_LEDS is not set
    > > CONFIG_LEDS_CLASS=y
    > >
    > > so drivers/leds/led-class.o should be linked into your vmlinux. But that
    > > obviously isn't happening.

    > Because CONFIG_NEW_LEDS is not set we do not visit drivers/leds due to:
    > obj-$(CONFIG_NEW_LEDS) += leds/
    > in drivers/Makefile
    >
    > This is evil select playing games (again).
    > We have LEDS_CLASS equal y but NEW_LEDS equal n
    >


    Ah, OK, thanks.

    I'll switch oz99x-i2c-button-and-led-support-driver.patch over to using
    non-evil `depends on LEDS_CLASS'.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [2.6.24-rc6-mm1] Build Failure on ppc64 with CONFIG_USB_GADGET not set.

    Hi,

    Am Montag 07 Januar 2008 schrieb Andrew Morton:
    > Sam Ravnborg wrote:
    > > This is evil select playing games (again).
    > > We have LEDS_CLASS equal y but NEW_LEDS equal n

    >
    > Ah, OK, thanks.
    >
    > I'll switch oz99x-i2c-button-and-led-support-driver.patch over to using
    > non-evil `depends on LEDS_CLASS'.


    If you wait a moment, I'll send you an updated patch that makes LED support
    optional in the driver.

    HS
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread