Re: [PATCH] isapnp driver semaphore to mutex - Kernel

This is a discussion on Re: [PATCH] isapnp driver semaphore to mutex - Kernel ; * Daniel Walker wrote: > Changed the isapnp semaphore to a mutex. cool - i'll give it a whirl. small immaterial nit: > Signed-Off-By: Daniel Walker it's Signed-off-by (note the capitalization). Having this consistent makes scripting around patches a tiny ...

+ Reply to Thread
Results 1 to 7 of 7

Thread: Re: [PATCH] isapnp driver semaphore to mutex

  1. Re: [PATCH] isapnp driver semaphore to mutex


    * Daniel Walker wrote:

    > Changed the isapnp semaphore to a mutex.


    cool - i'll give it a whirl.

    small immaterial nit:

    > Signed-Off-By: Daniel Walker


    it's Signed-off-by (note the capitalization). Having this consistent
    makes scripting around patches a tiny bit easier.

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] isapnp driver semaphore to mutex

    On Mon, 2007-12-03 at 16:57 +0100, Ingo Molnar wrote:
    > * Daniel Walker wrote:
    >
    > > Changed the isapnp semaphore to a mutex.

    >
    > cool - i'll give it a whirl.
    >
    > small immaterial nit:
    >
    > > Signed-Off-By: Daniel Walker

    >
    > it's Signed-off-by (note the capitalization). Having this consistent
    > makes scripting around patches a tiny bit easier.


    Yeah, I know about it but sometimes still slips by..

    Daniel

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] isapnp driver semaphore to mutex


    * Daniel Walker wrote:

    > On Mon, 2007-12-03 at 16:57 +0100, Ingo Molnar wrote:
    > > * Daniel Walker wrote:
    > >
    > > > Changed the isapnp semaphore to a mutex.

    > >
    > > cool - i'll give it a whirl.
    > >
    > > small immaterial nit:
    > >
    > > > Signed-Off-By: Daniel Walker

    > >
    > > it's Signed-off-by (note the capitalization). Having this consistent
    > > makes scripting around patches a tiny bit easier.

    >
    > Yeah, I know about it but sometimes still slips by..


    it's worth automating these repetative bits. I use small templates when
    creating patches. Also, it's worth running patches through
    scripts/checkpatch.pl - it has a check for exactly this typo. [ Not a
    big issue at all, i just mentioned it in case you get a taste for
    sending more sem2mutex patches :-) ]

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [PATCH] isapnp driver semaphore to mutex

    On Mon, 2007-12-03 at 17:47 +0100, Ingo Molnar wrote:
    > * Daniel Walker wrote:
    >
    > > On Mon, 2007-12-03 at 16:57 +0100, Ingo Molnar wrote:
    > > > * Daniel Walker wrote:
    > > >
    > > > > Changed the isapnp semaphore to a mutex.
    > > >
    > > > cool - i'll give it a whirl.
    > > >
    > > > small immaterial nit:
    > > >
    > > > > Signed-Off-By: Daniel Walker
    > > >
    > > > it's Signed-off-by (note the capitalization). Having this consistent
    > > > makes scripting around patches a tiny bit easier.

    > >
    > > Yeah, I know about it but sometimes still slips by..

    >
    > it's worth automating these repetative bits. I use small templates when
    > creating patches. Also, it's worth running patches through
    > scripts/checkpatch.pl - it has a check for exactly this typo. [ Not a
    > big issue at all, i just mentioned it in case you get a taste for
    > sending more sem2mutex patches :-) ]
    >


    Speaking of automating.. I created a little .vimrc add-on which helps
    doing sem2mutex type changes. Here's the chunk I added,

    function Semtomutex( lo )
    exe '%s/down(&'.a:lo.')/mutex_lock\(\&'.a:lo.'\)/g'
    exe '%s/down_trylock(&'.a:lo.')/mutex_trylock\(\&'.a:lo.'\)/g'
    exe '%s/up(&'.a:lo.')/mutex_unlock\(\&'.a:lo.'\)/g'
    exe '%s/DECLARE_MUTEX('.a:lo.')/DEFINE_MUTEX\('.a:lo.'\)/g'
    endfunction
    map o :call Semtomutex("")


    I just finished this about 30 seconds ago, and although I tested it once
    I would guess it might have some bugs.. If you add it to your .vimrc ,
    then you move your cursor over the lock name and hit Ctrl-\-o ,it will
    convert all the calls for that lock name.. The list of calls it converts
    isn't complete tho (down, down_trylock, and up) ..

    I hope people still review the lock usage tho, since it's critical.

    Daniel

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. Re: [PATCH] isapnp driver semaphore to mutex

    Dne Mon, 03 Dec 2007 10:35:01 -0800
    Daniel Walker napsal(a):

    > Speaking of automating.. I created a little .vimrc add-on which helps
    > doing sem2mutex type changes. Here's the chunk I added,
    >
    > function Semtomutex( lo )
    > exe '%s/down(&'.a:lo.')/mutex_lock\(\&'.a:lo.'\)/g'
    > exe '%s/down_trylock(&'.a:lo.')/mutex_trylock\(\&'.a:lo.'\)/g'


    From the comment above mutex_trylock():
    * NOTE: this function follows the spin_trylock() convention, so
    * it is negated to the down_trylock() return values! Be careful
    * about this when converting semaphore users to mutexes.

    Michal
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  6. Re: [PATCH] isapnp driver semaphore to mutex

    On Mon, 2007-12-03 at 17:47 +0100, Ingo Molnar wrote:
    > * Daniel Walker wrote:
    >
    > > On Mon, 2007-12-03 at 16:57 +0100, Ingo Molnar wrote:
    > > > * Daniel Walker wrote:
    > > >
    > > > > Changed the isapnp semaphore to a mutex.
    > > >
    > > > cool - i'll give it a whirl.
    > > >
    > > > small immaterial nit:
    > > >
    > > > > Signed-Off-By: Daniel Walker
    > > >
    > > > it's Signed-off-by (note the capitalization). Having this consistent
    > > > makes scripting around patches a tiny bit easier.

    > >
    > > Yeah, I know about it but sometimes still slips by..

    >
    > it's worth automating these repetative bits. I use small templates when
    > creating patches. Also, it's worth running patches through
    > scripts/checkpatch.pl - it has a check for exactly this typo. [ Not a
    > big issue at all, i just mentioned it in case you get a taste for
    > sending more sem2mutex patches :-) ]



    These are the patches, and files I've touched so far in case anyone is
    working on this .. These are all to be submitted.

    unix98-semaphore-to-mutex.patch
    linux-2.6.23/drivers/char/tty_io.c
    spi-semaphore-to-mutex.patch
    linux-2.6.23/drivers/spi/spi.c
    au1000-semaphore-to-mutex.patch
    linux-2.6.23/drivers/pcmcia/au1000_generic.c
    soc_common-semaphore-to-mutex.patch
    linux-2.6.23/drivers/pcmcia/soc_common.c
    linux-2.6.23/drivers/pcmcia/soc_common.h
    qla2xxx-semaphore-to-mutex.patch
    linux-2.6.23/drivers/scsi/qla2xxx/qla_os.c
    bcm43xx-semaphore-to-mutex.patch
    linux-2.6.23/drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c
    adb_handler_sem-to-mutex.patch
    linux-2.6.23/drivers/macintosh/adb.c

    Daniel

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  7. Re: [PATCH] isapnp driver semaphore to mutex

    On Mon, 2007-12-03 at 20:11 +0100, Michal Schmidt wrote:
    > Dne Mon, 03 Dec 2007 10:35:01 -0800
    > Daniel Walker napsal(a):
    >
    > > Speaking of automating.. I created a little .vimrc add-on which helps
    > > doing sem2mutex type changes. Here's the chunk I added,
    > >
    > > function Semtomutex( lo )
    > > exe '%s/down(&'.a:lo.')/mutex_lock\(\&'.a:lo.'\)/g'
    > > exe '%s/down_trylock(&'.a:lo.')/mutex_trylock\(\&'.a:lo.'\)/g'

    >
    > From the comment above mutex_trylock():
    > * NOTE: this function follows the spin_trylock() convention, so
    > * it is negated to the down_trylock() return values! Be careful
    > * about this when converting semaphore users to mutexes.
    >
    > Michal


    Thanks, I didn't notice this .. I've only run into one tho..

    Daniel

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread