Re: Oops with 2.6.24 git when loading iwl3945 - Kernel

This is a discussion on Re: Oops with 2.6.24 git when loading iwl3945 - Kernel ; [Thomas Tuttle - Tue, Nov 27, 2007 at 03:43:57PM -0500] | Hey. | | I'm using a git snapshot that gentoo distributed mere hours ago (so I'm | fairly confident it's current), and I'm getting an Oops when I try ...

+ Reply to Thread
Results 1 to 5 of 5

Thread: Re: Oops with 2.6.24 git when loading iwl3945

  1. Re: Oops with 2.6.24 git when loading iwl3945

    [Thomas Tuttle - Tue, Nov 27, 2007 at 03:43:57PM -0500]
    | Hey.
    |
    | I'm using a git snapshot that gentoo distributed mere hours ago (so I'm
    | fairly confident it's current), and I'm getting an Oops when I try to
    | load the iwl3945 driver. I've attached it as plain text.
    |
    | Hope this helps,
    |
    | Thomas Tuttle

    Hi Thomas,
    Could you please test the patch?

    Cyrill
    ---

    Seems just mutex unlock is missed

    net/mac80211/ieee80211_rate.c | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/net/mac80211/ieee80211_rate.c b/net/mac80211/ieee80211_rate.c
    index 7254bd6..3260a4a 100644
    --- a/net/mac80211/ieee80211_rate.c
    +++ b/net/mac80211/ieee80211_rate.c
    @@ -33,6 +33,7 @@ int ieee80211_rate_control_register(struct rate_control_ops *ops)
    if (!strcmp(alg->ops->name, ops->name)) {
    /* don't register an algorithm twice */
    WARN_ON(1);
    + mutex_unlock(&rate_ctrl_mutex);
    return -EALREADY;
    }
    }
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: Oops with 2.6.24 git when loading iwl3945

    On Sun, 2 Dec 2007 19:43:16 +0300, "Cyrill Gorcunov"
    said:
    > [Thomas Tuttle - Tue, Nov 27, 2007 at 03:43:57PM -0500]
    > | Hey.
    > |
    > | I'm using a git snapshot that gentoo distributed mere hours ago (so I'm
    > | fairly confident it's current), and I'm getting an Oops when I try to
    > | load the iwl3945 driver. I've attached it as plain text.
    > |
    > | Hope this helps,
    > |
    > | Thomas Tuttle
    >
    > Hi Thomas,
    > Could you please test the patch?


    It didn't help. The original oops says the problem was in strcmp. It
    was a GPF, which suggests to me that one of the arguments is NULL.
    Since ops->name is checked at the beginning of the function, the only
    other possibility is that alg->ops->name is NULL. I added a bit of code
    to check for this, and it turns out that one of the strings was indeed
    NULL. I didn't know where to go from there in debugging, but I hope it
    helps.

    Thanks,

    Thomas Tuttle
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: Oops with 2.6.24 git when loading iwl3945

    [Thomas Tuttle - Sun, Dec 02, 2007 at 12:46:01PM -0500]
    | On Sun, 2 Dec 2007 19:43:16 +0300, "Cyrill Gorcunov"
    | said:
    | > [Thomas Tuttle - Tue, Nov 27, 2007 at 03:43:57PM -0500]
    | > | Hey.
    | > |
    | > | I'm using a git snapshot that gentoo distributed mere hours ago (so I'm
    | > | fairly confident it's current), and I'm getting an Oops when I try to
    | > | load the iwl3945 driver. I've attached it as plain text.
    | > |
    | > | Hope this helps,
    | > |
    | > | Thomas Tuttle
    | >
    | > Hi Thomas,
    | > Could you please test the patch?
    |
    | It didn't help. The original oops says the problem was in strcmp. It
    | was a GPF, which suggests to me that one of the arguments is NULL.
    | Since ops->name is checked at the beginning of the function, the only
    | other possibility is that alg->ops->name is NULL. I added a bit of code
    | to check for this, and it turns out that one of the strings was indeed
    | NULL. I didn't know where to go from there in debugging, but I hope it
    | helps.
    |
    | Thanks,
    |
    | Thomas Tuttle
    |

    thanks, i do know that problem is in strcmp, i just thought the reason
    of bug was a delayed procedure execution 'case of missing mutex unlock.
    Have to dig deeper

    Cyrill

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: Oops with 2.6.24 git when loading iwl3945

    On 12/2/07, Thomas Tuttle wrote:
    > On Sun, 2 Dec 2007 19:43:16 +0300, "Cyrill Gorcunov"
    > said:
    > > [Thomas Tuttle - Tue, Nov 27, 2007 at 03:43:57PM -0500]
    > > | Hey.
    > > |
    > > | I'm using a git snapshot that gentoo distributed mere hours ago (so I'm
    > > | fairly confident it's current), and I'm getting an Oops when I try to
    > > | load the iwl3945 driver. I've attached it as plain text.
    > > |
    > > | Hope this helps,
    > > |
    > > | Thomas Tuttle
    > >
    > > Hi Thomas,
    > > Could you please test the patch?

    >
    > It didn't help. The original oops says the problem was in strcmp. It
    > was a GPF, which suggests to me that one of the arguments is NULL.
    > Since ops->name is checked at the beginning of the function, the only
    > other possibility is that alg->ops->name is NULL. I added a bit of code
    > to check for this, and it turns out that one of the strings was indeed
    > NULL. I didn't know where to go from there in debugging, but I hope it
    > helps.
    >
    > Thanks,
    >
    > Thomas Tuttle
    >

    Hi Thomas,
    could you please attach your kernel's .config (and in bugzilla too).
    Thanks.

    Cyrill
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. Re: Oops with 2.6.24 git when loading iwl3945

    [Thomas Tuttle - Sun, Dec 02, 2007 at 12:46:01PM -0500]
    | On Sun, 2 Dec 2007 19:43:16 +0300, "Cyrill Gorcunov"
    | said:
    | > [Thomas Tuttle - Tue, Nov 27, 2007 at 03:43:57PM -0500]
    | > | Hey.
    | > |
    | > | I'm using a git snapshot that gentoo distributed mere hours ago (so I'm
    | > | fairly confident it's current), and I'm getting an Oops when I try to
    | > | load the iwl3945 driver. I've attached it as plain text.
    | > |
    | > | Hope this helps,
    | > |
    | > | Thomas Tuttle
    | >
    | > Hi Thomas,
    | > Could you please test the patch?
    |
    | It didn't help. The original oops says the problem was in strcmp. It
    | was a GPF, which suggests to me that one of the arguments is NULL.
    | Since ops->name is checked at the beginning of the function, the only
    | other possibility is that alg->ops->name is NULL. I added a bit of code
    | to check for this, and it turns out that one of the strings was indeed
    | NULL. I didn't know where to go from there in debugging, but I hope it
    | helps.
    |
    | Thanks,
    |
    | Thomas Tuttle
    |

    Hi Thomas,

    could you please try that one
    Ayway as my previous patch and this one have to be applied anyway (regardless
    the OOPs you catched). So I've sent previous patch to list and this one too,
    but that is more important for - does these (both) patch helped. Thanks a lot
    for patience (i know the problem is in strcmp but it seems that is a side issue -
    main problems seems to be in sych. events)

    Cyrill
    ---

    From: Cyrill Gorcunov
    Date: Mon, 3 Dec 2007 22:12:30 +0300
    Subject: [PATCH] [PATCH] NET: mac80211 - fix inappropriate memory freeing

    This patch does fix inappropriate memory freeing in case
    of requested rate_control_ops was not found. In this case
    the list head entity is going to be accidently wasted.

    Signed-off-by: Cyrill Gorcunov
    ---
    net/mac80211/ieee80211_rate.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/net/mac80211/ieee80211_rate.c b/net/mac80211/ieee80211_rate.c
    index 3260a4a..c3f2783 100644
    --- a/net/mac80211/ieee80211_rate.c
    +++ b/net/mac80211/ieee80211_rate.c
    @@ -60,11 +60,11 @@ void ieee80211_rate_control_unregister(struct rate_control_ops *ops)
    list_for_each_entry(alg, &rate_ctrl_algs, list) {
    if (alg->ops == ops) {
    list_del(&alg->list);
    + kfree(alg);
    break;
    }
    }
    mutex_unlock(&rate_ctrl_mutex);
    - kfree(alg);
    }
    EXPORT_SYMBOL(ieee80211_rate_control_unregister);

    --
    1.5.3.5

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread