From: Julia Lawall

There should be a pci_dev_put when breaking out of a loop that iterates
over calls to pci_get_device and similar functions.

In this case, the return under the initial if needs a pci_dev_put in the
same way that the return under the subsequent for loop has a pci_dev_put.

This was fixed using the following semantic patch.

//
@@
type T;
identifier d;
expression e;
@@

T *d;
....
while ((d = \(pci_get_device\|pci_get_device_reverse\|pci_get_ subsys\|pci_get_class\)(..., d)) != NULL)
{... when != pci_dev_put(d)
when != e = d
(
return d;
|
+ pci_dev_put(d);
? return ...;
)
....}
//


Signed-off-by: Julia Lawall
---

diff -u -p a/sound/core/memalloc.c b/sound/core/memalloc.c
--- a/sound/core/memalloc.c 2007-10-22 11:25:51.000000000 +0200
+++ b/sound/core/memalloc.c 2007-11-19 08:08:08.000000000 +0100
@@ -568,6 +568,7 @@ static ssize_t snd_mem_proc_write(struct
if (pci_set_dma_mask(pci, mask) < 0 ||
pci_set_consistent_dma_mask(pci, mask) < 0) {
printk(KERN_ERR "snd-page-alloc: cannot set DMA mask %lx for pci %04x:%04x\n", mask, vendor, device);
+ pci_dev_put(pci);
return count;
}
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/