[PATCH] restore arch/ppc/boot cflags - Kernel

This is a discussion on [PATCH] restore arch/ppc/boot cflags - Kernel ; Commit 9a39e273d4df0560c724c5fe71f6314a0583ca2b removed the boot directory addition to CFLAGS that was being used by the subdirectory builds. For the other files, that patch set EXTRA_CFLAGS, but Makefile.build explicitly sets that to empty as it is explicitly for a single directory ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] restore arch/ppc/boot cflags

  1. [PATCH] restore arch/ppc/boot cflags

    Commit 9a39e273d4df0560c724c5fe71f6314a0583ca2b removed the boot directory
    addition to CFLAGS that was being used by the subdirectory builds. For the
    other files, that patch set EXTRA_CFLAGS, but Makefile.build explicitly
    sets that to empty as it is explicitly for a single directory only.
    Append to KBUILD_CFLAGS instead.

    Signed-off-by: Milton Miller
    ---
    The commit also changed xtensia to export EXTRA_CFLAGS from its boot
    directory, that needs to be fixed too.

    from ARCH=ppc prep_defconfig:

    /data/home/miltonm/work.git/arch/ppc/boot/of1275/write.c:11:20: error: of1275.h: No such file or directory
    /data/home/miltonm/work.git/arch/ppc/boot/of1275/read.c:11:20:/data/home/miltonm/work.git/arch/ppc/boot/of1275/ofstdio.c:11:20: error: error: of1275.h: No such file or directoryof1275.h: No such file or directory
    /data/home/miltonm/work.git/arch/ppc/boot/of1275/release.c:11:20: error: of1275.h: No such file or directory
    /data/home/miltonm/work.git/arch/ppc/boot/of1275/ofinit.c:11:20: error: of1275.h: No such file or directory
    /data/home/miltonm/work.git/arch/ppc/boot/of1275/map.c:12:22: error: nonstdio.h: No such file or directory
    /data/home/miltonm/work.git/arch/ppc/boot/of1275/map.c:11:20: error: of1275.h: No such file or directory
    /data/home/miltonm/work.git/arch/ppc/boot/of1275/getprop.c:11:20: error: of1275.h: No such file or directory
    /data/home/miltonm/work.git/arch/ppc/boot/common/ns16550.c:14:20: error: serial.h: No such file or directory
    /data/home/miltonm/work.git/arch/ppc/boot/common/ns16550.c:13:22: error: nonstdio.h: No such file or directory
    /data/home/miltonm/work.git/arch/ppc/boot/of1275/enter.c:11:20: error: of1275.h: No such file or directory
    error: of1275.h: No such file or directory
    /data/home/miltonm/work.git/arch/ppc/boot/of1275/claim.c:12:22: error: nonstdio.h: No such file or directory
    /data/home/miltonm/work.git/arch/ppc/boot/of1275/claim.c:11:20: error: of1275.h: No such file or directory
    /data/home/miltonm/work.git/arch/ppc/boot/of1275/finddevice.c:11:20: error: of1275.h: No such file or directory
    /data/home/miltonm/work.git/arch/ppc/boot/common/bootinfo.c:14:22: error: nonstdio.h: No such file or directory
    /data/home/miltonm/work.git/arch/ppc/boot/common/misc-common.c:18:22: error: nonstdio.h: No such file or directory
    of1275.h: No such file or directory


    diff --git a/arch/ppc/boot/Makefile b/arch/ppc/boot/Makefile
    index 487dc66..52a0d38 100644
    --- a/arch/ppc/boot/Makefile
    +++ b/arch/ppc/boot/Makefile
    @@ -13,6 +13,7 @@
    # modified by Cort (cort@cs.nmt.edu)
    #

    +KBUILD_CFLAGS += -fno-builtin -D__BOOTER__ -Iarch/$(ARCH)/boot/include
    HOSTCFLAGS += -Iarch/$(ARCH)/boot/include

    BOOT_TARGETS = zImage zImage.initrd znetboot znetboot.initrd
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] restore arch/ppc/boot cflags

    On Sat, Oct 20, 2007 at 03:58:03AM -0500, Milton Miller wrote:
    > Commit 9a39e273d4df0560c724c5fe71f6314a0583ca2b removed the boot directory
    > addition to CFLAGS that was being used by the subdirectory builds. For the
    > other files, that patch set EXTRA_CFLAGS, but Makefile.build explicitly
    > sets that to empty as it is explicitly for a single directory only.
    > Append to KBUILD_CFLAGS instead.


    Neat - I had not figured out that the assignmnet took effect
    recursively.
    I have applied following patch.

    Sam

    From 437374e9a95062fe310b901e48585691edaf5dd0 Mon Sep 17 00:00:00 2001
    From: Milton Miller
    Date: Sat, 20 Oct 2007 03:58:03 -0500
    Subject: [PATCH] kbuild: restore arch/{ppc/xtensa}/boot cflags

    Commit 9a39e273d4df0560c724c5fe71f6314a0583ca2b removed the boot directory
    addition to CFLAGS that was being used by the subdirectory builds. For the
    other files, that patch set EXTRA_CFLAGS, but Makefile.build explicitly
    sets that to empty as it is explicitly for a single directory only.
    Append to KBUILD_CFLAGS instead.

    Signed-off-by: Milton Miller
    Signed-off-by: Sam Ravnborg
    ---
    arch/ppc/boot/Makefile | 2 ++
    arch/xtensa/boot/Makefile | 3 ++-
    2 files changed, 4 insertions(+), 1 deletions(-)

    diff --git a/arch/ppc/boot/Makefile b/arch/ppc/boot/Makefile
    index 487dc66..500497e 100644
    --- a/arch/ppc/boot/Makefile
    +++ b/arch/ppc/boot/Makefile
    @@ -13,6 +13,8 @@
    # modified by Cort (cort@cs.nmt.edu)
    #

    +# KBUILD_CFLAGS used when building rest of boot (takes effect recursively)
    +KBUILD_CFLAGS += -fno-builtin -D__BOOTER__ -Iarch/$(ARCH)/boot/include
    HOSTCFLAGS += -Iarch/$(ARCH)/boot/include

    BOOT_TARGETS = zImage zImage.initrd znetboot znetboot.initrd
    diff --git a/arch/xtensa/boot/Makefile b/arch/xtensa/boot/Makefile
    index 9c5185f..40aa55b 100644
    --- a/arch/xtensa/boot/Makefile
    +++ b/arch/xtensa/boot/Makefile
    @@ -8,7 +8,8 @@
    #


    -EXTRA_CFLAGS += -fno-builtin -Iarch/$(ARCH)/boot/include
    +# KBUILD_CFLAGS used when building rest of boot (takes effect recursively)
    +KBUILD_CFLAGS += -fno-builtin -Iarch/$(ARCH)/boot/include
    HOSTFLAGS += -Iarch/$(ARCH)/boot/include

    BIG_ENDIAN := $(shell echo -e __XTENSA_EB__ | $(CC) -E - | grep -v "\#")
    --
    1.5.3.4.206.g58ba4

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread