kbuild: kconfig source with " " or not - Kernel

This is a discussion on kbuild: kconfig source with " " or not - Kernel ; Sam, in Kconfig, most of source to include other kconfig has "..." for example: in arch/x86_64/Kconfig: source "net/Kconfig" but some other don't better to keep them consistent YH - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: kbuild: kconfig source with " " or not

  1. kbuild: kconfig source with " " or not

    Sam,

    in Kconfig, most of source to include other kconfig has "..."

    for example:

    in arch/x86_64/Kconfig:
    source "net/Kconfig"

    but some other don't

    < ./drivers/w1/Kconfig:source drivers/w1/masters/Kconfig
    < ./drivers/w1/Kconfig:source drivers/w1/slaves/Kconfig
    < ./drivers/i2c/Kconfig:source drivers/i2c/algos/Kconfig
    < ./drivers/i2c/Kconfig:source drivers/i2c/busses/Kconfig
    < ./drivers/i2c/Kconfig:source drivers/i2c/chips/Kconfig
    < ./arch/frv/Kconfig:source kernel/power/Kconfig
    < ./arch/v850/Kconfig:source init/Kconfig
    < ./arch/v850/Kconfig:source drivers/mtd/Kconfig
    < ./arch/v850/Kconfig:source drivers/parport/Kconfig
    < ./arch/v850/Kconfig:#source drivers/pnp/Kconfig
    < ./arch/v850/Kconfig:source drivers/block/Kconfig
    < ./arch/v850/Kconfig:#source drivers/misc/Config.in
    < ./arch/ia64/Kconfig:source kernel/Kconfig.hz
    < ./arch/i386/Kconfig:source kernel/Kconfig.hz
    < ./arch/i386/Kconfig:source kernel/power/Kconfig
    < ./arch/ppc/Kconfig:source arch/ppc/platforms/4xx/Kconfig
    < ./arch/ppc/Kconfig:source arch/ppc/platforms/85xx/Kconfig
    < ./arch/ppc/Kconfig:source kernel/Kconfig.hz
    < ./arch/ppc/Kconfig:source kernel/Kconfig.preempt
    < ./arch/ppc/Kconfig:source kernel/power/Kconfig
    < ./arch/x86_64/Kconfig:source kernel/Kconfig.hz
    < ./arch/x86_64/Kconfig:source kernel/power/Kconfig
    < ./arch/x86_64/Kconfig:source drivers/Kconfig
    < ./arch/x86_64/Kconfig:source fs/Kconfig
    < ./arch/s390/Kconfig:source kernel/Kconfig.hz
    < ./arch/cris/Kconfig:source mm/Kconfig
    < ./arch/cris/Kconfig:source arch/cris/arch-v10/Kconfig
    < ./arch/cris/Kconfig:source arch/cris/arch-v10/drivers/Kconfig
    < ./arch/cris/Kconfig:#source drivers/misc/Config.in
    < ./arch/powerpc/Kconfig:source kernel/time/Kconfig
    < ./arch/powerpc/Kconfig:source kernel/Kconfig.hz
    < ./arch/powerpc/Kconfig:source kernel/Kconfig.preempt
    < ./arch/powerpc/Kconfig:source kernel/power/Kconfig
    < ./arch/sh64/Kconfig:source init/Kconfig
    < ./arch/sh/Kconfig:source kernel/Kconfig.hz
    < ./arch/sh/Kconfig:source kernel/power/Kconfig
    < ./arch/sparc64/Kconfig:source kernel/Kconfig.hz
    < ./arch/arm/Kconfig:source arch/arm/mm/Kconfig
    < ./arch/blackfin/Kconfig:source kernel/Kconfig.hz
    < ./block/Kconfig:source block/Kconfig.iosched
    < ./security/Kconfig:source security/selinux/Kconfig

    better to keep them consistent

    YH
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: kbuild: kconfig source with " " or not

    Hi Yinghai.

    On Sat, Oct 20, 2007 at 12:30:50AM -0700, Yinghai Lu wrote:
    > Sam,
    >
    > in Kconfig, most of source to include other kconfig has "..."
    >
    > for example:
    >
    > in arch/x86_64/Kconfig:
    > source "net/Kconfig"
    >
    > but some other don't
    >
    > < ./drivers/w1/Kconfig:source drivers/w1/masters/Kconfig
    > < ./drivers/w1/Kconfig:source drivers/w1/slaves/Kconfig
    > < ./drivers/i2c/Kconfig:source drivers/i2c/algos/Kconfig
    > < ./drivers/i2c/Kconfig:source drivers/i2c/busses/Kconfig
    > < ./drivers/i2c/Kconfig:source drivers/i2c/chips/Kconfig
    > < ./arch/frv/Kconfig:source kernel/power/Kconfig
    > < ./arch/v850/Kconfig:source init/Kconfig
    > < ./arch/v850/Kconfig:source drivers/mtd/Kconfig
    > < ./arch/v850/Kconfig:source drivers/parport/Kconfig
    > < ./arch/v850/Kconfig:#source drivers/pnp/Kconfig
    > < ./arch/v850/Kconfig:source drivers/block/Kconfig
    > < ./arch/v850/Kconfig:#source drivers/misc/Config.in
    > < ./arch/ia64/Kconfig:source kernel/Kconfig.hz
    > < ./arch/i386/Kconfig:source kernel/Kconfig.hz
    > < ./arch/i386/Kconfig:source kernel/power/Kconfig
    > < ./arch/ppc/Kconfig:source arch/ppc/platforms/4xx/Kconfig
    > < ./arch/ppc/Kconfig:source arch/ppc/platforms/85xx/Kconfig
    > < ./arch/ppc/Kconfig:source kernel/Kconfig.hz
    > < ./arch/ppc/Kconfig:source kernel/Kconfig.preempt
    > < ./arch/ppc/Kconfig:source kernel/power/Kconfig
    > < ./arch/x86_64/Kconfig:source kernel/Kconfig.hz
    > < ./arch/x86_64/Kconfig:source kernel/power/Kconfig
    > < ./arch/x86_64/Kconfig:source drivers/Kconfig
    > < ./arch/x86_64/Kconfig:source fs/Kconfig
    > < ./arch/s390/Kconfig:source kernel/Kconfig.hz
    > < ./arch/cris/Kconfig:source mm/Kconfig
    > < ./arch/cris/Kconfig:source arch/cris/arch-v10/Kconfig
    > < ./arch/cris/Kconfig:source arch/cris/arch-v10/drivers/Kconfig
    > < ./arch/cris/Kconfig:#source drivers/misc/Config.in
    > < ./arch/powerpc/Kconfig:source kernel/time/Kconfig
    > < ./arch/powerpc/Kconfig:source kernel/Kconfig.hz
    > < ./arch/powerpc/Kconfig:source kernel/Kconfig.preempt
    > < ./arch/powerpc/Kconfig:source kernel/power/Kconfig
    > < ./arch/sh64/Kconfig:source init/Kconfig
    > < ./arch/sh/Kconfig:source kernel/Kconfig.hz
    > < ./arch/sh/Kconfig:source kernel/power/Kconfig
    > < ./arch/sparc64/Kconfig:source kernel/Kconfig.hz
    > < ./arch/arm/Kconfig:source arch/arm/mm/Kconfig
    > < ./arch/blackfin/Kconfig:source kernel/Kconfig.hz
    > < ./block/Kconfig:source block/Kconfig.iosched
    > < ./security/Kconfig:source security/selinux/Kconfig
    >
    > better to keep them consistent


    Agree - but on the other hand we do not want an all-over-the-tree
    patch to fix it up.
    If you are up to fix it then please send the patches to the
    relevant subsystem/arch maintainers.
    When we are almost done we could let kconfig warn if "" is missing.

    PS. Added linux-kbuild@vger.kernel.org

    Sam
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread