[2.6 patch] ide/pci/sis5513.c: add missing "else" - Kernel

This is a discussion on [2.6 patch] ide/pci/sis5513.c: add missing "else" - Kernel ; This patch adds a missing "else" that was missing in commit c77a89cd98d99819f23a4a08e5e17ee1f13f6e4d. Spotted by the Coverity checker. Signed-off-by: Adrian Bunk --- 2e4b8d4f58ea45e55c87ba5563b0d0e135cac2b4 diff --git a/drivers/ide/pci/sis5513.c b/drivers/ide/pci/sis5513.c index c1d280b..1680926 100644 --- a/drivers/ide/pci/sis5513.c +++ b/drivers/ide/pci/sis5513.c @@ -264,7 +264,7 @@ static void sis_ata133_program_timings(ide_drive_t ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [2.6 patch] ide/pci/sis5513.c: add missing "else"

  1. [2.6 patch] ide/pci/sis5513.c: add missing "else"

    This patch adds a missing "else" that was missing in
    commit c77a89cd98d99819f23a4a08e5e17ee1f13f6e4d.

    Spotted by the Coverity checker.

    Signed-off-by: Adrian Bunk

    ---
    2e4b8d4f58ea45e55c87ba5563b0d0e135cac2b4
    diff --git a/drivers/ide/pci/sis5513.c b/drivers/ide/pci/sis5513.c
    index c1d280b..1680926 100644
    --- a/drivers/ide/pci/sis5513.c
    +++ b/drivers/ide/pci/sis5513.c
    @@ -264,7 +264,7 @@ static void sis_ata133_program_timings(ide_drive_t *drive, const u8 mode)
    if (mode >= XFER_MW_DMA_0) {
    t1 &= ~0x04; /* disable UDMA */
    idx = mode - XFER_MW_DMA_0 + 5;
    - }
    + } else
    idx = mode - XFER_PIO_0;
    t1 |= ini_time_value[clk][idx] << 12;
    t1 |= act_time_value[clk][idx] << 16;

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [2.6 patch] ide/pci/sis5513.c: add missing "else"

    On Friday 19 October 2007, Adrian Bunk wrote:
    > This patch adds a missing "else" that was missing in
    > commit c77a89cd98d99819f23a4a08e5e17ee1f13f6e4d.
    >
    > Spotted by the Coverity checker.
    >
    > Signed-off-by: Adrian Bunk


    applied, thanks!

    > ---
    > 2e4b8d4f58ea45e55c87ba5563b0d0e135cac2b4
    > diff --git a/drivers/ide/pci/sis5513.c b/drivers/ide/pci/sis5513.c
    > index c1d280b..1680926 100644
    > --- a/drivers/ide/pci/sis5513.c
    > +++ b/drivers/ide/pci/sis5513.c
    > @@ -264,7 +264,7 @@ static void sis_ata133_program_timings(ide_drive_t *drive, const u8 mode)
    > if (mode >= XFER_MW_DMA_0) {
    > t1 &= ~0x04; /* disable UDMA */
    > idx = mode - XFER_MW_DMA_0 + 5;
    > - }
    > + } else
    > idx = mode - XFER_PIO_0;
    > t1 |= ini_time_value[clk][idx] << 12;
    > t1 |= act_time_value[clk][idx] << 16;

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread