[PATCH] bluetooth: Eliminate checks for impossible conditions in irq handler - Kernel

This is a discussion on [PATCH] bluetooth: Eliminate checks for impossible conditions in irq handler - Kernel ; commit 1c8073a42f133bf5780099c1e6efd9e48468cd29 Author: Jeff Garzik Date: Fri Oct 19 03:07:30 2007 -0400 [BLUETOOTH] Eliminate checks for impossible conditions in irq handler Our info structure and info->hdev is always passed to the irq handler, so we don't have to worry about ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] bluetooth: Eliminate checks for impossible conditions in irq handler

  1. [PATCH] bluetooth: Eliminate checks for impossible conditions in irq handler


    commit 1c8073a42f133bf5780099c1e6efd9e48468cd29
    Author: Jeff Garzik
    Date: Fri Oct 19 03:07:30 2007 -0400

    [BLUETOOTH] Eliminate checks for impossible conditions in irq handler

    Our info structure and info->hdev is always passed to the irq handler,
    so we don't have to worry about these checks in every interrupt.

    Leave a BUG_ON() just to help unwary programmers, but these could
    probably be removed as well.

    Signed-off-by: Jeff Garzik

    drivers/bluetooth/bluecard_cs.c | 5 +----
    drivers/bluetooth/bt3c_cs.c | 5 +----
    drivers/bluetooth/btuart_cs.c | 5 +----
    drivers/bluetooth/dtl1_cs.c | 5 +----
    4 files changed, 4 insertions(+), 16 deletions(-)

    1c8073a42f133bf5780099c1e6efd9e48468cd29
    diff --git a/drivers/bluetooth/bluecard_cs.c b/drivers/bluetooth/bluecard_cs.c
    index 851de4d..bcf5792 100644
    --- a/drivers/bluetooth/bluecard_cs.c
    +++ b/drivers/bluetooth/bluecard_cs.c
    @@ -503,10 +503,7 @@ static irqreturn_t bluecard_interrupt(int irq, void *dev_inst)
    unsigned int iobase;
    unsigned char reg;

    - if (!info || !info->hdev) {
    - BT_ERR("Call of irq %d for unknown device", irq);
    - return IRQ_NONE;
    - }
    + BUG_ON(!info->hdev);

    if (!test_bit(CARD_READY, &(info->hw_state)))
    return IRQ_HANDLED;
    diff --git a/drivers/bluetooth/bt3c_cs.c b/drivers/bluetooth/bt3c_cs.c
    index 3951607..a18f9b8 100644
    --- a/drivers/bluetooth/bt3c_cs.c
    +++ b/drivers/bluetooth/bt3c_cs.c
    @@ -344,10 +344,7 @@ static irqreturn_t bt3c_interrupt(int irq, void *dev_inst)
    unsigned int iobase;
    int iir;

    - if (!info || !info->hdev) {
    - BT_ERR("Call of irq %d for unknown device", irq);
    - return IRQ_NONE;
    - }
    + BUG_ON(!info->hdev);

    iobase = info->p_dev->io.BasePort1;

    diff --git a/drivers/bluetooth/btuart_cs.c b/drivers/bluetooth/btuart_cs.c
    index d7d2ea0..08f48d5 100644
    --- a/drivers/bluetooth/btuart_cs.c
    +++ b/drivers/bluetooth/btuart_cs.c
    @@ -294,10 +294,7 @@ static irqreturn_t btuart_interrupt(int irq, void *dev_inst)
    int boguscount = 0;
    int iir, lsr;

    - if (!info || !info->hdev) {
    - BT_ERR("Call of irq %d for unknown device", irq);
    - return IRQ_NONE;
    - }
    + BUG_ON(!info->hdev);

    iobase = info->p_dev->io.BasePort1;

    diff --git a/drivers/bluetooth/dtl1_cs.c b/drivers/bluetooth/dtl1_cs.c
    index 7f9c54b..dae45cd 100644
    --- a/drivers/bluetooth/dtl1_cs.c
    +++ b/drivers/bluetooth/dtl1_cs.c
    @@ -298,10 +298,7 @@ static irqreturn_t dtl1_interrupt(int irq, void *dev_inst)
    int boguscount = 0;
    int iir, lsr;

    - if (!info || !info->hdev) {
    - BT_ERR("Call of irq %d for unknown device", irq);
    - return IRQ_NONE;
    - }
    + BUG_ON(!info->hdev);

    iobase = info->p_dev->io.BasePort1;

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [Bluez-devel] [PATCH] bluetooth: Eliminate checks for impossible conditions in irq handler

    Hi Jeff,

    > [BLUETOOTH] Eliminate checks for impossible conditions in irq handler
    >
    > Our info structure and info->hdev is always passed to the irq handler,
    > so we don't have to worry about these checks in every interrupt.
    >
    > Leave a BUG_ON() just to help unwary programmers, but these could
    > probably be removed as well.


    applied to my tree. Thanks.

    Regards

    Marcel


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread