[RFC][PATCH -mm] Freezer: Do not allow freezing processes to clear TIF_SIGPENDING - Kernel

This is a discussion on [RFC][PATCH -mm] Freezer: Do not allow freezing processes to clear TIF_SIGPENDING - Kernel ; From: Rafael J. Wysocki Do not allow processes to clear their TIF_SIGPENDING if TIF_FREEZE is set, to prevent them from racing with the freezer (like mysqld does, for example). Signed-off-by: Rafael J. Wysocki --- kernel/signal.c | 2 +- 1 file ...

+ Reply to Thread
Results 1 to 4 of 4

Thread: [RFC][PATCH -mm] Freezer: Do not allow freezing processes to clear TIF_SIGPENDING

  1. [RFC][PATCH -mm] Freezer: Do not allow freezing processes to clear TIF_SIGPENDING

    From: Rafael J. Wysocki

    Do not allow processes to clear their TIF_SIGPENDING if TIF_FREEZE is set,
    to prevent them from racing with the freezer (like mysqld does, for example).

    Signed-off-by: Rafael J. Wysocki
    ---
    kernel/signal.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    Index: linux-2.6.23-mm1/kernel/signal.c
    ================================================== =================
    --- linux-2.6.23-mm1.orig/kernel/signal.c
    +++ linux-2.6.23-mm1/kernel/signal.c
    @@ -124,7 +124,7 @@ void recalc_sigpending_and_wake(struct t

    void recalc_sigpending(void)
    {
    - if (!recalc_sigpending_tsk(current))
    + if (!recalc_sigpending_tsk(current) && !freezing(current))
    clear_thread_flag(TIF_SIGPENDING);

    }
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [RFC][PATCH -mm] Freezer: Do not allow freezing processes to clear TIF_SIGPENDING

    Hi.

    On Friday 19 October 2007 08:22:35 Rafael J. Wysocki wrote:
    > From: Rafael J. Wysocki
    >
    > Do not allow processes to clear their TIF_SIGPENDING if TIF_FREEZE is set,
    > to prevent them from racing with the freezer (like mysqld does, for

    example).
    >
    > Signed-off-by: Rafael J. Wysocki


    Acked-by: Nigel Cunningham

    > ---
    > kernel/signal.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > Index: linux-2.6.23-mm1/kernel/signal.c
    > ================================================== =================
    > --- linux-2.6.23-mm1.orig/kernel/signal.c
    > +++ linux-2.6.23-mm1/kernel/signal.c
    > @@ -124,7 +124,7 @@ void recalc_sigpending_and_wake(struct t
    >
    > void recalc_sigpending(void)
    > {
    > - if (!recalc_sigpending_tsk(current))
    > + if (!recalc_sigpending_tsk(current) && !freezing(current))
    > clear_thread_flag(TIF_SIGPENDING);
    >
    > }
    >




    --
    Nigel, Michelle, Alisdair and ____________ Cunningham
    5 Mitchell Street
    Cobden 3266
    Victoria, Australia
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [RFC][PATCH -mm] Freezer: Do not allow freezing processes to clear TIF_SIGPENDING

    On Fri 2007-10-19 00:22:35, Rafael J. Wysocki wrote:
    > From: Rafael J. Wysocki
    >
    > Do not allow processes to clear their TIF_SIGPENDING if TIF_FREEZE is set,
    > to prevent them from racing with the freezer (like mysqld does, for example).
    >
    > Signed-off-by: Rafael J. Wysocki


    ACK. We want this in 2.6.24.
    Pavel

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pav...rses/blog.html
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [RFC][PATCH -mm] Freezer: Do not allow freezing processes to clear TIF_SIGPENDING

    On Friday, 19 October 2007 09:55, Pavel Machek wrote:
    > On Fri 2007-10-19 00:22:35, Rafael J. Wysocki wrote:
    > > From: Rafael J. Wysocki
    > >
    > > Do not allow processes to clear their TIF_SIGPENDING if TIF_FREEZE is set,
    > > to prevent them from racing with the freezer (like mysqld does, for example).
    > >
    > > Signed-off-by: Rafael J. Wysocki

    >
    > ACK. We want this in 2.6.24.


    Sure, we do.

    Greetings,
    Rafael
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread