[PATCH] Use task_pid_nr() instead of pid_nr(task_pid()) - Kernel

This is a discussion on [PATCH] Use task_pid_nr() instead of pid_nr(task_pid()) - Kernel ; There are two places that do so - the cgroups subsystem and the autofs code. Signed-off-by: Pavel Emelyanov --- diff --git a/fs/autofs/root.c b/fs/autofs/root.c index 592f640..5efff3c 100644 --- a/fs/autofs/root.c +++ b/fs/autofs/root.c @@ -214,7 +214,7 @@ static struct dentry *autofs_root_lookup oz_mode = ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: [PATCH] Use task_pid_nr() instead of pid_nr(task_pid())

  1. [PATCH] Use task_pid_nr() instead of pid_nr(task_pid())

    There are two places that do so - the cgroups subsystem
    and the autofs code.

    Signed-off-by: Pavel Emelyanov

    ---

    diff --git a/fs/autofs/root.c b/fs/autofs/root.c
    index 592f640..5efff3c 100644
    --- a/fs/autofs/root.c
    +++ b/fs/autofs/root.c
    @@ -214,7 +214,7 @@ static struct dentry *autofs_root_lookup

    oz_mode = autofs_oz_mode(sbi);
    DPRINTK(("autofs_lookup: pid = %u, pgrp = %u, catatonic = %d, "
    - "oz_mode = %d\n", pid_nr(task_pid(current)),
    + "oz_mode = %d\n", task_pid_nr(current),
    task_pgrp_nr(current), sbi->catatonic,
    oz_mode));

    diff --git a/kernel/cgroup.c b/kernel/cgroup.c
    index 1e8aa53..8720881 100644
    --- a/kernel/cgroup.c
    +++ b/kernel/cgroup.c
    @@ -1762,7 +1762,7 @@ static int pid_array_load(pid_t *pidarra
    while ((tsk = cgroup_iter_next(cont, &it))) {
    if (unlikely(n == npids))
    break;
    - pidarray[n++] = pid_nr(task_pid(tsk));
    + pidarray[n++] = task_pid_nr(tsk);
    }
    cgroup_iter_end(cont, &it);
    return n;

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] Use task_pid_nr() instead of pid_nr(task_pid())

    On Wed, 03 Oct 2007 18:26:06 +0400
    Pavel Emelyanov wrote:

    > There are two places that do so - the cgroups subsystem
    > and the autofs code.
    >
    > Signed-off-by: Pavel Emelyanov
    >
    > ---
    >
    > diff --git a/fs/autofs/root.c b/fs/autofs/root.c
    > index 592f640..5efff3c 100644
    > --- a/fs/autofs/root.c
    > +++ b/fs/autofs/root.c
    > @@ -214,7 +214,7 @@ static struct dentry *autofs_root_lookup
    >
    > oz_mode = autofs_oz_mode(sbi);
    > DPRINTK(("autofs_lookup: pid = %u, pgrp = %u, catatonic = %d, "
    > - "oz_mode = %d\n", pid_nr(task_pid(current)),
    > + "oz_mode = %d\n", task_pid_nr(current),
    > task_pgrp_nr(current), sbi->catatonic,
    > oz_mode));
    >
    > diff --git a/kernel/cgroup.c b/kernel/cgroup.c
    > index 1e8aa53..8720881 100644
    > --- a/kernel/cgroup.c
    > +++ b/kernel/cgroup.c
    > @@ -1762,7 +1762,7 @@ static int pid_array_load(pid_t *pidarra
    > while ((tsk = cgroup_iter_next(cont, &it))) {
    > if (unlikely(n == npids))
    > break;
    > - pidarray[n++] = pid_nr(task_pid(tsk));
    > + pidarray[n++] = task_pid_nr(tsk);
    > }
    > cgroup_iter_end(cont, &it);
    > return n;


    And more will appear over time unless we remove pid_nr() altogether.

    Can we do that?
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] Use task_pid_nr() instead of pid_nr(task_pid())

    Andrew Morton wrote:
    > On Wed, 03 Oct 2007 18:26:06 +0400
    > Pavel Emelyanov wrote:
    >
    >> There are two places that do so - the cgroups subsystem
    >> and the autofs code.
    >>
    >> Signed-off-by: Pavel Emelyanov
    >>
    >> ---
    >>
    >> diff --git a/fs/autofs/root.c b/fs/autofs/root.c
    >> index 592f640..5efff3c 100644
    >> --- a/fs/autofs/root.c
    >> +++ b/fs/autofs/root.c
    >> @@ -214,7 +214,7 @@ static struct dentry *autofs_root_lookup
    >>
    >> oz_mode = autofs_oz_mode(sbi);
    >> DPRINTK(("autofs_lookup: pid = %u, pgrp = %u, catatonic = %d, "
    >> - "oz_mode = %d\n", pid_nr(task_pid(current)),
    >> + "oz_mode = %d\n", task_pid_nr(current),
    >> task_pgrp_nr(current), sbi->catatonic,
    >> oz_mode));
    >>
    >> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
    >> index 1e8aa53..8720881 100644
    >> --- a/kernel/cgroup.c
    >> +++ b/kernel/cgroup.c
    >> @@ -1762,7 +1762,7 @@ static int pid_array_load(pid_t *pidarra
    >> while ((tsk = cgroup_iter_next(cont, &it))) {
    >> if (unlikely(n == npids))
    >> break;
    >> - pidarray[n++] = pid_nr(task_pid(tsk));
    >> + pidarray[n++] = task_pid_nr(tsk);
    >> }
    >> cgroup_iter_end(cont, &it);
    >> return n;

    >
    > And more will appear over time unless we remove pid_nr() altogether.
    >
    > Can we do that?


    Hardly.

    There are places that store the struct pid and try to obtain its number
    later. E.g. tiocgpgrp() wants to tell user the pgrp nr of the tty's
    active group; fgetown() tells user the number of file's owner pid or (!)
    pgrp; file locks need to store the pid and report it later (this is not
    implemented yet, I'm still working on it) and so on and so forth.

    Thanks,
    Pavel
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread