Re: [PATCH] JBD/ext34 cleanups: convert to kzalloc - Kernel

This is a discussion on Re: [PATCH] JBD/ext34 cleanups: convert to kzalloc - Kernel ; On Fri, 21 Sep 2007 16:13:56 -0700 Mingming Cao wrote: > Convert kmalloc to kzalloc() and get rid of the memset(). I split this into separate ext3/jbd and ext4/jbd2 patches. It's generally better to raise separate patches, please - the ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: Re: [PATCH] JBD/ext34 cleanups: convert to kzalloc

  1. Re: [PATCH] JBD/ext34 cleanups: convert to kzalloc

    On Fri, 21 Sep 2007 16:13:56 -0700
    Mingming Cao wrote:

    > Convert kmalloc to kzalloc() and get rid of the memset().


    I split this into separate ext3/jbd and ext4/jbd2 patches. It's generally
    better to raise separate patches, please - the ext3 patches I'll merge
    directly but the ext4 patches should go through (and be against) the ext4
    devel tree.

    I fixed lots of rejects against the already-pending changes to these
    filesystems.

    You forgot to remove the memsets in both start_this_handle()s.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] JBD/ext34 cleanups: convert to kzalloc

    On Wed, 2007-09-26 at 12:54 -0700, Andrew Morton wrote:
    > On Fri, 21 Sep 2007 16:13:56 -0700
    > Mingming Cao wrote:
    >
    > > Convert kmalloc to kzalloc() and get rid of the memset().

    >
    > I split this into separate ext3/jbd and ext4/jbd2 patches. It's generally
    > better to raise separate patches, please - the ext3 patches I'll merge
    > directly but the ext4 patches should go through (and be against) the ext4
    > devel tree.
    >

    Sure. The patches(including ext3/jbd and ext4/jbd2) were merged into
    ext4 devel tree already, I will remove the ext3/jbd part out of the ext4
    devel tree.

    > I fixed lots of rejects against the already-pending changes to these
    > filesystems.
    >
    > You forgot to remove the memsets in both start_this_handle()s.
    >

    Thanks for catching this.

    Mingming

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread