Re: [uml-devel] [PATCH] UML - Fix irqstack crash
On luned́ 24 settembre 2007, Jeff Dike wrote:[color=blue]
> On Thu, Sep 20, 2007 at 05:57:49PM +0200, Paolo Giarrusso wrote:[color=green]
> > Yes, indeed - or sign extension on 64bit machines would set to 1 the
> > whole high-word.
> > But using long for that mask makes no difference; either int or long
> > long (or better, either u32 or u64) should be used, given that the
> > used signal range is the same on 32 and 64bit machines, it should
> > be u32 for normal signals or u64 if RT-signals are also allowed.[/color]
> We don't use RT signals for anything, so we could use u32.[/color]
I wasn't sure of that.[color=blue]
> I don't
> see it making much difference though.[/color]
Agreed - the only difference is for cleanliness and easy verification.
"Doh!" (cit.), I've made another mistake!
Paolo Giarrusso, aka Blaisorblade
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
-----END PGP SIGNATURE-----