[PATCH] Remove unused member from nsproxy - Kernel

This is a discussion on [PATCH] Remove unused member from nsproxy - Kernel ; The nslock spinlock is not used in the kernel at all. Remove it. Signed-off-by: Pavel Emelyanov --- diff --git a/include/linux/init_task.h b/include/linux/init_task.h index a3f2541..cae35b6 100644 --- a/include/linux/init_task.h +++ b/include/linux/init_task.h @@ -73,7 +73,6 @@ extern struct nsproxy init_nsproxy; #define INIT_NSPROXY(nsproxy) { \ ...

+ Reply to Thread
Results 1 to 4 of 4

Thread: [PATCH] Remove unused member from nsproxy

  1. [PATCH] Remove unused member from nsproxy

    The nslock spinlock is not used in the kernel at all.
    Remove it.

    Signed-off-by: Pavel Emelyanov

    ---

    diff --git a/include/linux/init_task.h b/include/linux/init_task.h
    index a3f2541..cae35b6 100644
    --- a/include/linux/init_task.h
    +++ b/include/linux/init_task.h
    @@ -73,7 +73,6 @@ extern struct nsproxy init_nsproxy;
    #define INIT_NSPROXY(nsproxy) { \
    .pid_ns = &init_pid_ns, \
    .count = ATOMIC_INIT(1), \
    - .nslock = __SPIN_LOCK_UNLOCKED(nsproxy.nslock), \
    .uts_ns = &init_uts_ns, \
    .mnt_ns = NULL, \
    INIT_NET_NS(net_ns) \
    diff --git a/include/linux/nsproxy.h b/include/linux/nsproxy.h
    index 4d564d8..0e66b57 100644
    --- a/include/linux/nsproxy.h
    +++ b/include/linux/nsproxy.h
    @@ -23,7 +23,6 @@ struct pid_namespace;
    */
    struct nsproxy {
    atomic_t count;
    - spinlock_t nslock;
    struct uts_namespace *uts_ns;
    struct ipc_namespace *ipc_ns;
    struct mnt_namespace *mnt_ns;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] Remove unused member from nsproxy

    Quoting Pavel Emelyanov (xemul@openvz.org):
    > The nslock spinlock is not used in the kernel at all.
    > Remove it.
    >
    > Signed-off-by: Pavel Emelyanov


    Acked-by: Serge Hallyn

    > ---
    >
    > diff --git a/include/linux/init_task.h b/include/linux/init_task.h
    > index a3f2541..cae35b6 100644
    > --- a/include/linux/init_task.h
    > +++ b/include/linux/init_task.h
    > @@ -73,7 +73,6 @@ extern struct nsproxy init_nsproxy;
    > #define INIT_NSPROXY(nsproxy) { \
    > .pid_ns = &init_pid_ns, \
    > .count = ATOMIC_INIT(1), \
    > - .nslock = __SPIN_LOCK_UNLOCKED(nsproxy.nslock), \
    > .uts_ns = &init_uts_ns, \
    > .mnt_ns = NULL, \
    > INIT_NET_NS(net_ns) \
    > diff --git a/include/linux/nsproxy.h b/include/linux/nsproxy.h
    > index 4d564d8..0e66b57 100644
    > --- a/include/linux/nsproxy.h
    > +++ b/include/linux/nsproxy.h
    > @@ -23,7 +23,6 @@ struct pid_namespace;
    > */
    > struct nsproxy {
    > atomic_t count;
    > - spinlock_t nslock;
    > struct uts_namespace *uts_ns;
    > struct ipc_namespace *ipc_ns;
    > struct mnt_namespace *mnt_ns;

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] Remove unused member from nsproxy

    Pavel Emelyanov wrote:
    > The nslock spinlock is not used in the kernel at all.


    it's also useless now that you have put some RCU rules around it.
    right ?

    C.

    > Remove it.
    > Signed-off-by: Pavel Emelyanov
    >
    > ---
    >
    > diff --git a/include/linux/init_task.h b/include/linux/init_task.h
    > index a3f2541..cae35b6 100644
    > --- a/include/linux/init_task.h
    > +++ b/include/linux/init_task.h
    > @@ -73,7 +73,6 @@ extern struct nsproxy init_nsproxy;
    > #define INIT_NSPROXY(nsproxy) { \
    > .pid_ns = &init_pid_ns, \
    > .count = ATOMIC_INIT(1), \
    > - .nslock = __SPIN_LOCK_UNLOCKED(nsproxy.nslock), \
    > .uts_ns = &init_uts_ns, \
    > .mnt_ns = NULL, \
    > INIT_NET_NS(net_ns) \
    > diff --git a/include/linux/nsproxy.h b/include/linux/nsproxy.h
    > index 4d564d8..0e66b57 100644
    > --- a/include/linux/nsproxy.h
    > +++ b/include/linux/nsproxy.h
    > @@ -23,7 +23,6 @@ struct pid_namespace;
    > */
    > struct nsproxy {
    > atomic_t count;
    > - spinlock_t nslock;
    > struct uts_namespace *uts_ns;
    > struct ipc_namespace *ipc_ns;
    > struct mnt_namespace *mnt_ns;
    > _______________________________________________
    > Containers mailing list
    > Containers@lists.linux-foundation.org
    > https://lists.linux-foundation.org/m...nfo/containers
    >


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [PATCH] Remove unused member from nsproxy

    Cedric Le Goater wrote:
    > Pavel Emelyanov wrote:
    >> The nslock spinlock is not used in the kernel at all.

    >
    > it's also useless now that you have put some RCU rules around it.
    > right ?


    Exactly!

    > C.
    >
    >> Remove it.
    >> Signed-off-by: Pavel Emelyanov
    >>
    >> ---
    >>
    >> diff --git a/include/linux/init_task.h b/include/linux/init_task.h
    >> index a3f2541..cae35b6 100644
    >> --- a/include/linux/init_task.h
    >> +++ b/include/linux/init_task.h
    >> @@ -73,7 +73,6 @@ extern struct nsproxy init_nsproxy;
    >> #define INIT_NSPROXY(nsproxy) { \
    >> .pid_ns = &init_pid_ns, \
    >> .count = ATOMIC_INIT(1), \
    >> - .nslock = __SPIN_LOCK_UNLOCKED(nsproxy.nslock), \
    >> .uts_ns = &init_uts_ns, \
    >> .mnt_ns = NULL, \
    >> INIT_NET_NS(net_ns) \
    >> diff --git a/include/linux/nsproxy.h b/include/linux/nsproxy.h
    >> index 4d564d8..0e66b57 100644
    >> --- a/include/linux/nsproxy.h
    >> +++ b/include/linux/nsproxy.h
    >> @@ -23,7 +23,6 @@ struct pid_namespace;
    >> */
    >> struct nsproxy {
    >> atomic_t count;
    >> - spinlock_t nslock;
    >> struct uts_namespace *uts_ns;
    >> struct ipc_namespace *ipc_ns;
    >> struct mnt_namespace *mnt_ns;
    >> _______________________________________________
    >> Containers mailing list
    >> Containers@lists.linux-foundation.org
    >> https://lists.linux-foundation.org/m...nfo/containers
    >>

    >
    > -
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/
    >


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread