Re: [PATCH 2/6] LBS: fix uninitialized swapper_space - Kernel

This is a discussion on Re: [PATCH 2/6] LBS: fix uninitialized swapper_space - Kernel ; On Fri, 21 Sep 2007, Hugh Dickins wrote: > Swapping crashed immediately: must initialize new fields of swapper_space. Thanks for finding that. It may be better though to use the new mapping_setup() function instead? That way there is no #ifdef. ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: Re: [PATCH 2/6] LBS: fix uninitialized swapper_space

  1. Re: [PATCH 2/6] LBS: fix uninitialized swapper_space

    On Fri, 21 Sep 2007, Hugh Dickins wrote:

    > Swapping crashed immediately: must initialize new fields of swapper_space.


    Thanks for finding that. It may be better though to use the new
    mapping_setup() function instead? That way there is no #ifdef.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH 2/6] LBS: fix uninitialized swapper_space

    On Mon, 24 Sep 2007, Christoph Lameter wrote:
    > On Fri, 21 Sep 2007, Hugh Dickins wrote:
    >
    > > Swapping crashed immediately: must initialize new fields of swapper_space.

    >
    > Thanks for finding that. It may be better though to use the new
    > mapping_setup() function instead? That way there is no #ifdef.


    Probably better, yes. In -mm Peter is doing an #ifdef CONFIG_SWAP
    bdi_init() on swapper_space. Would make sense to do both together,
    perhaps move them to a swapper_space_init() in swap_state.c, saving
    his #ifdef too. I suggest leave such cleanups until one or the
    other is mainlined.

    Hugh
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH 2/6] LBS: fix uninitialized swapper_space

    On Wed, 26 Sep 2007, Hugh Dickins wrote:

    > Probably better, yes. In -mm Peter is doing an #ifdef CONFIG_SWAP
    > bdi_init() on swapper_space. Would make sense to do both together,
    > perhaps move them to a swapper_space_init() in swap_state.c, saving
    > his #ifdef too. I suggest leave such cleanups until one or the
    > other is mainlined.


    Ok. I have updated the largeblock git tree with your patches and a new
    revision of the mmap patches. Still working on it. Fallback in the block
    layer is not yet working. I probably need to look at Nick's patches a bit.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread