[PATCH] sched: cleanup adjusting sched_class - Kernel

This is a discussion on [PATCH] sched: cleanup adjusting sched_class - Kernel ; Hi Ingo and Dmitry, I made a clean-up patch about fixing invalid sched_class use. Dmitry, could you please review and sign it? The adjusting sched_class is a missing part of the already existing "do not leak PI boosting priority to ...

+ Reply to Thread
Results 1 to 4 of 4

Thread: [PATCH] sched: cleanup adjusting sched_class

  1. [PATCH] sched: cleanup adjusting sched_class

    Hi Ingo and Dmitry,

    I made a clean-up patch about fixing invalid sched_class use.

    Dmitry, could you please review and sign it?


    The adjusting sched_class is a missing part of the already existing
    "do not leak PI boosting priority to the child" at the sched_fork().
    This patch moves the adjusting sched_class from wake_up_new_task()
    to sched_fork().

    Signed-off-by: Hiroshi Shimamoto
    ---

    diff --git a/kernel/sched.c b/kernel/sched.c
    index 6107a0c..8862761 100644
    --- a/kernel/sched.c
    +++ b/kernel/sched.c
    @@ -1641,6 +1641,8 @@ void sched_fork(struct task_struct *p, int clone_flags)
    * Make sure we do not leak PI boosting priority to the child:
    */
    p->prio = current->normal_prio;
    + if (!rt_prio(p->prio))
    + p->sched_class = &fair_sched_class;

    #if defined(CONFIG_SCHEDSTATS) || defined(CONFIG_TASK_DELAY_ACCT)
    if (likely(sched_info_on()))
    @@ -1682,11 +1684,6 @@ void fastcall wake_up_new_task(struct task_struct *p, unsigned long clone_flags)

    p->prio = effective_prio(p);

    - if (rt_prio(p->prio))
    - p->sched_class = &rt_sched_class;
    - else
    - p->sched_class = &fair_sched_class;
    -
    if (!p->sched_class->task_new || !sysctl_sched_child_runs_first ||
    (clone_flags & CLONE_VM) || task_cpu(p) != this_cpu ||
    !current->se.on_rq) {


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] sched: cleanup adjusting sched_class

    On 24/09/2007, Hiroshi Shimamoto wrote:
    > Hi Ingo and Dmitry,
    >
    > I made a clean-up patch about fixing invalid sched_class use.


    thanks!

    >
    > Dmitry, could you please review and sign it?
    >
    >
    > The adjusting sched_class is a missing part of the already existing
    > "do not leak PI boosting priority to the child" at the sched_fork().
    > This patch moves the adjusting sched_class from wake_up_new_task()
    > to sched_fork().
    >
    > Signed-off-by: Hiroshi Shimamoto


    Signed-off-by: Dmitry Adamushko


    --
    Best regards,
    Dmitry Adamushko
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] sched: cleanup adjusting sched_class


    * Hiroshi Shimamoto wrote:

    > Hi Ingo and Dmitry,
    >
    > I made a clean-up patch about fixing invalid sched_class use.
    >
    > Dmitry, could you please review and sign it?
    >
    >
    > The adjusting sched_class is a missing part of the already existing
    > "do not leak PI boosting priority to the child" at the sched_fork().
    > This patch moves the adjusting sched_class from wake_up_new_task() to
    > sched_fork().


    thanks. Note that your cleanup also shrinks the code a bit:

    text data bss dec hex filename
    40111 4018 292 44421 ad85 sched.o.before
    40102 4018 292 44412 ad7c sched.o.after

    which never hurts

    Ingo
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [PATCH] sched: cleanup adjusting sched_class


    * Dmitry Adamushko wrote:

    > On 24/09/2007, Hiroshi Shimamoto wrote:
    > > Hi Ingo and Dmitry,
    > >
    > > I made a clean-up patch about fixing invalid sched_class use.

    >
    > thanks!
    >
    > >
    > > Dmitry, could you please review and sign it?
    > >
    > >
    > > The adjusting sched_class is a missing part of the already existing
    > > "do not leak PI boosting priority to the child" at the sched_fork().
    > > This patch moves the adjusting sched_class from wake_up_new_task()
    > > to sched_fork().
    > >
    > > Signed-off-by: Hiroshi Shimamoto

    >
    > Signed-off-by: Dmitry Adamushko


    thanks - i've picked up Hiroshi's cleanup.

    Ingo
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread