--Boundary-00=_x5aHE2j37HP/Gwy
Content-Type: text/plain;
charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Coolo,

Michael Pyne has committed a patch for this issue. rev 520376 on
branches/kdebase/kcontrol/access/kaccess.cpp.

See this thread

http://lists.kde.org/?l=kde-devel&m=114270811112568&w=2

bug:123924

I was not able to duplicate the crash on kde startup (probably just dumb
luck), but I believe this is showstopper and should be included in 3.5.2 rc.

Michael's patch is attached.

Thanks.

On Saturday 18 March 2006 13:54, Dave Rowe wrote:
> Hello,
> It appears that in SVN on the 3.5 branch, a mistake in the logic of a for
> loop may be causing the KDE Accessibility tool to crash on startup of KDE.
>
> I believe the attached patch fixes this crash.
>
> Please review and let me know if it's okay to commit.
>
> Thanks,
> Dave
> dave@roweware.com


--
Gary Cramblitt (aka PhantomsDad)
KDE Text-to-Speech Maintainer
http://accessibility.kde.org/developer/kttsd/index.php

--Boundary-00=_x5aHE2j37HP/Gwy
Content-Type: text/x-diff;
charset="utf-8";
name="kaccess_cpp.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="kaccess_cpp.patch"

Index: kaccess.cpp
================================================== =================
--- kaccess.cpp (revision 520372)
+++ kaccess.cpp (revision 520379)
@@ -337,7 +337,7 @@
keys [i] = -1;
state = 0;

- for (int i = 0; modifierKeys[i].name; i++) {
+ for (int i = 0; strcmp (modifierKeys[i].name, "") != 0; i++) {
int mask = modifierKeys[i].mask;
if (mask == 0)
if (modifierKeys[i].keysym != 0)

--Boundary-00=_x5aHE2j37HP/Gwy
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


--Boundary-00=_x5aHE2j37HP/Gwy--