--===============2101310347==
Content-Type: multipart/signed;
boundary="nextPart1166168.8u3dynkXZU";
protocol="application/pgp-signature";
micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart1166168.8u3dynkXZU
Content-Type: text/plain;
charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Friday 16 September 2005 13:07, Ivor Hewitt wrote:
> [System Tray]
> systrayIconWidth=3D16
>
> to config/kdeglobals
>
> This is an existing setting that is read by the KSystray base class but n=

ot
> used by the tray applet.
>
> Although this won't work for tray apps that don't use a sized icon
> (kcpuload).


i'm really concerned this will break on people's system given the odd ways=
=20
apps use the system tray, but as it stays at 24px by default and only those=
=20
with the audacity to change it will get burnt, i'm cool with that.

there's a bug in your patch though:

+ int m_iconWidth =3D conf->readNumEntry("systrayIconWidth", 22);

the leading "int" shouldn't be there =3D)

also, please initialize m_iconWidth in the initalizer list in the ctor to 24

+ conf->setGroup("System Tray");

this should probably just be the General group. the config file is already=
=20
specific to the applet. so just move it up a few lines =3D)

with those changes, i'm fine with you committing this.

=2D-=20
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43

=46ull time KDE developer sponsored by Trolltech (http://www.trolltech.com)

--nextPart1166168.8u3dynkXZU
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQBDK3XU1rcusafx20MRAr7FAJ92xYQvWEpYQbH1hqF9pF 6QBdQsGgCgjCzx
3q+pswfVXcMaalfctmIafYU=
=+vq3
-----END PGP SIGNATURE-----

--nextPart1166168.8u3dynkXZU--

--===============2101310347==
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

=

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscrib=

e <<

--===============2101310347==--