Re: kern/127446: [patch] fix race in sys/dev/kbdmux/kbdmux.c - FreeBSD

This is a discussion on Re: kern/127446: [patch] fix race in sys/dev/kbdmux/kbdmux.c - FreeBSD ; Me again. Tue, Sep 23, 2008 at 12:28:24PM +0400, Eygene Ryabinkin wrote: > The attached patch does this. I did some limited testing for it: still > continuing to do it on all available systems. New patch works on 7.0 ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: Re: kern/127446: [patch] fix race in sys/dev/kbdmux/kbdmux.c

  1. Re: kern/127446: [patch] fix race in sys/dev/kbdmux/kbdmux.c

    Me again.

    Tue, Sep 23, 2008 at 12:28:24PM +0400, Eygene Ryabinkin wrote:
    > The attached patch does this. I did some limited testing for it: still
    > continuing to do it on all available systems.


    New patch works on 7.0 and 7.0-PRERELEASE, but currently hangs my
    7.1-PRERELEASE just before activation of the single-user mode. I am
    investigating -- I did the original patch for the syscons.c 1.453.2.1.
    Changes in 1.453.2.2 look innocently, but 1.453.2.3 changed some
    functionality, may be it is the culprit. Will inform on my findings.
    --
    Eygene
    _ ___ _.--. #
    \`.|\..----...-'` `-._.-'_.-'` # Remember that it is hard
    / ' ` , __.--' # to read the on-line manual
    )/' _/ \ `-_, / # while single-stepping the kernel.
    `-'" `"\_ ,_.-;_.-\_ ', fsc/as #
    _.-'_./ {_.' ; / # -- FreeBSD Developers handbook
    {_.-``-' {_/ #

    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v2.0.9 (FreeBSD)

    iEUEARECAAYFAkjYsi8ACgkQthUKNsbL7YjwmgCWLA15gffo1c mwo9fGys6rZGEL
    wACgjE7eJ1eLEFVp7OrV8T3wfHiAx+4=
    =WTpN
    -----END PGP SIGNATURE-----


  2. Re: kern/127446: [patch] fix race in sys/dev/kbdmux/kbdmux.c

    Tue, Sep 23, 2008 at 01:09:03PM +0400, Eygene Ryabinkin wrote:
    > New patch works on 7.0 and 7.0-PRERELEASE, but currently hangs my
    > 7.1-PRERELEASE just before activation of the single-user mode. I am
    > investigating -- I did the original patch for the syscons.c 1.453.2.1.
    > Changes in 1.453.2.2 look innocently, but 1.453.2.3 changed some
    > functionality, may be it is the culprit. Will inform on my findings.


    It turned that locking inside sc_cnputc() was redundant and errorneous:
    WITNESS quicky advised me not to do it. Forgot to run locking subsystem
    checks, sorry for that.

    The attached patch was tested on two 7.1-PRERELEASE systems (i386 and
    amd64, both with and without X), on 7.0-STABLE and 7.0-RELEASE-p3 (i386,
    only console, no X) and on rather old 8-CURRENT from Jul 1, syscons.c
    revision 1.459 (amd64 both with and without X). Works fine for me.

    8.x needs slightly modified patch due to the naming changes. Also
    attached it. Will try a fresher -CURRENT in some hours: Ed did massive
    changes due to the MPSAFE tty layer, so may be this patch won't be
    needed for the modern 8-CURRENT.
    --
    Eygene
    _ ___ _.--. #
    \`.|\..----...-'` `-._.-'_.-'` # Remember that it is hard
    / ' ` , __.--' # to read the on-line manual
    )/' _/ \ `-_, / # while single-stepping the kernel.
    `-'" `"\_ ,_.-;_.-\_ ', fsc/as #
    _.-'_./ {_.' ; / # -- FreeBSD Developers handbook
    {_.-``-' {_/ #

    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v2.0.9 (FreeBSD)

    iEYEARECAAYFAkjYvsoACgkQthUKNsbL7YjJFQCffM8DomRrMB OwhQPnqn3ab3Js
    e80An0f7H0egC+dEcV0jDgCFK0MmEVKQ
    =v79M
    -----END PGP SIGNATURE-----


+ Reply to Thread