* Matthew Palmer [2008-10-22 11:34]:
> I wasn't sure if adding an extra udeb into the initrd was acceptable; since
> it's OK, I've reworked the patch to do that instead. New patch attached,
> with tests this time (I forgot to include them in the diff last time).

Thanks, this looks good.

+# Parse the sib.conf file, as found in the Dlink DNS-323

D-Link

+ # I can't see anywhere this is configured, so we'll hard-code it
+ # for now
+ INTERFACE="eth0"

There's only one network interface, so this comment is not necessary.

+ mkdir -p $path/rootfs
+ mount -t minix /dev/$rootfs $path/rootfs

I suggest you mount it read-only (as the others do)

+ NETMASK=255.255.255.0
+ GATEWAY=192.168.1.254
+ [ -z "$NAMESERVERS" ] && NAMESERVERS=192.168.1.254

Is this the default setting in the firmware?


--- /dev/null
+++ b/packages/oldsys-preseed/tests/arm/dns323.preseed

Maybe this should be called dns323-static.

+++ b/packages/oldsys-preseed/tests/arm/dns323.test

Same.

Thanks again for working on this!
--
Martin Michlmayr
http://www.cyrius.com/



--
To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

On Wed, Oct 22, 2008 at 05:26:24PM +0200, Martin Michlmayr wrote:
> * Matthew Palmer [2008-10-22 11:34]:
> > I wasn't sure if adding an extra udeb into the initrd was acceptable; since
> > it's OK, I've reworked the patch to do that instead. New patch attached,
> > with tests this time (I forgot to include them in the diff last time).
>
> Thanks, this looks good.
>
> +# Parse the sib.conf file, as found in the Dlink DNS-323
>
> D-Link

Fixed.

> + # I can't see anywhere this is configured, so we'll hard-code it
> + # for now
> + INTERFACE="eth0"
>
> There's only one network interface, so this comment is not necessary.

I assume that it's just the *comment* that's not necessary, but the
INTERFACE=eth0 still is? All the other orion5x-based devices hardcode it.

> + mkdir -p $path/rootfs
> + mount -t minix /dev/$rootfs $path/rootfs
>
> I suggest you mount it read-only (as the others do)

Done.

>
> + NETMASK=255.255.255.0
> + GATEWAY=192.168.1.254
> + [ -z "$NAMESERVERS" ] && NAMESERVERS=192.168.1.254
>
> Is this the default setting in the firmware?

I'm not sure what the default in the firmware actually is, I'll have to
look it up in The Fine Manual later tonight. I'll attach a fixed patch when
I've done that.

- Matt



--
To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org