Bug#502058: maybe_break fails if $break is undefined - Debian

This is a discussion on Bug#502058: maybe_break fails if $break is undefined - Debian ; Package: initramfs-tools Version: 0.92j Severity: important File: /usr/share/initramfs-tools/scripts/functions X-Debbugs-Cc: acid@debian.org Tags: patch initramfs-tools breaks mdadm, which uses set -eu. So when it calls maybe_break, the script dies: Begin: Running /scripts/local-top ... /scripts/local-top/mdadm: 15: break: parameter not set The patch is ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: Bug#502058: maybe_break fails if $break is undefined

  1. Bug#502058: maybe_break fails if $break is undefined

    Package: initramfs-tools
    Version: 0.92j
    Severity: important
    File: /usr/share/initramfs-tools/scripts/functions
    X-Debbugs-Cc: acid@debian.org
    Tags: patch

    initramfs-tools breaks mdadm, which uses set -eu. So when it calls
    maybe_break, the script dies:

    Begin: Running /scripts/local-top ...
    /scripts/local-top/mdadm: 15: break: parameter not set

    The patch is simply to use:

    if [ "${break:-}" = "$1" ]; then

    instead of

    if [ "${break}" = "$1" ]; then

    on line 58 of scripts/functions.

    The problem should also happen with 0.92l, but I cannot reproduce
    it.

    The workaround for mdadm in this case is to pass break=top at the
    kernel boot prompt, and then hit ^D (ctrl-d) when initramfs-tools
    presents the shell.

    Julien, can you please confirm that this works when you get home
    tonight?

    -- Package-specific info:
    -- /proc/cmdline
    root=/dev/disk/by-uuid/cbef70d0-231c-474e-9bd1-d74f874426ab ro nmi_watchdog=2

    -- /proc/filesystems
    ext3
    vfat
    fuseblk

    -- lsmod
    Module Size Used by
    fuse 53184 1
    nls_utf8 6272 0
    nls_cp437 11136 0
    vfat 14976 0
    fat 51128 1 vfat
    nls_base 12932 4 nls_utf8,nls_cp437,vfat,fat
    ppp_deflate 9216 0
    zlib_deflate 23960 1 ppp_deflate
    zlib_inflate 18944 1 ppp_deflate
    bsd_comp 9600 0
    ppp_async 13056 0
    crc_ccitt 6528 1 ppp_async
    ppp_generic 27816 3 ppp_deflate,bsd_comp,ppp_async
    slhc 10112 1 ppp_generic
    bnep 17024 2
    rfcomm 38176 5
    l2cap 23936 13 bnep,rfcomm
    wacom 22144 0
    radeon 133920 0
    drm 91488 1 radeon
    video 24084 0
    output 7808 1 video
    ac 9352 0
    battery 16904 0
    nfsd 248360 17
    auth_rpcgss 47520 1 nfsd
    exportfs 8704 1 nfsd
    nfs 251696 1
    lockd 68560 2 nfsd,nfs
    nfs_acl 7552 2 nfsd,nfs
    sunrpc 197480 17 nfsd,auth_rpcgss,nfs,lockd,nfs_acl
    bridge 53544 0
    tun 14084 1
    ipv6 288328 42
    ipt_MASQUERADE 7296 2
    iptable_nat 9872 1
    nf_nat 23192 2 ipt_MASQUERADE,iptable_nat
    ipt_REJECT 7552 1
    xt_tcpudp 7680 26
    ipt_LOG 10116 1
    xt_limit 7172 1
    nf_conntrack_ipv4 19352 9 iptable_nat,nf_nat
    xt_conntrack 8704 6
    ipt_addrtype 6912 2
    iptable_filter 7424 1
    ip_tables 21520 2 iptable_nat,iptable_filter
    x_tables 25224 9 ipt_MASQUERADE,iptable_nat,ipt_REJECT,xt_tcpudp,ip t_LOG,xt_limit,xt_conntrack,ipt_addrtype,ip_tables
    dm_crypt 17032 0
    crypto_blkcipher 21636 1 dm_crypt
    nf_conntrack_ftp 12728 0
    nf_conntrack 71440 6 ipt_MASQUERADE,iptable_nat,nf_nat,nf_conntrack_ipv 4,xt_conntrack,nf_conntrack_ftp
    snd_pcm_oss 41760 0
    snd_mixer_oss 18816 1 snd_pcm_oss
    usbhid 45792 0
    hci_usb 18460 2
    hid 41792 1 usbhid
    bluetooth 57124 8 bnep,rfcomm,l2cap,hci_usb
    ff_memless 9224 1 usbhid
    usb_storage 94400 0
    serio_raw 9860 0
    snd_via82xx 28712 1
    gameport 17040 1 snd_via82xx
    psmouse 42268 0
    snd_mpu401_uart 11776 1 snd_via82xx
    snd_pcsp 14588 0
    snd_seq_midi 11072 0
    snd_rawmidi 26784 2 snd_mpu401_uart,snd_seq_midi
    snd_seq_dummy 7428 0
    snd_via82xx_modem 16396 0
    snd_ac97_codec 115416 2 snd_via82xx,snd_via82xx_modem
    k8temp 9216 0
    snd_seq_oss 33152 0
    ac97_bus 6272 1 snd_ac97_codec
    snd_seq_midi_event 11904 2 snd_seq_midi,snd_seq_oss
    snd_seq 54304 6 snd_seq_midi,snd_seq_dummy,snd_seq_oss,snd_seq_mid i_event
    snd_seq_device 11668 5 snd_seq_midi,snd_rawmidi,snd_seq_dummy,snd_seq_oss ,snd_seq
    snd_pcm 81800 5 snd_pcm_oss,snd_via82xx,snd_pcsp,snd_via82xx_modem ,snd_ac97_codec
    snd_timer 25744 2 snd_seq,snd_pcm
    snd_page_alloc 13072 3 snd_via82xx,snd_via82xx_modem,snd_pcm
    snd 63688 15 snd_pcm_oss,snd_mixer_oss,snd_via82xx,snd_mpu401_u art,snd_pcsp,snd_rawmidi,snd_via82xx_modem,snd_ac9 7_codec,snd_seq_oss,snd_seq,snd_seq_device,snd_pcm ,snd_timer
    soundcore 12064 1 snd
    i2c_viapro 12440 0
    i2c_core 27936 1 i2c_viapro
    shpchp 34080 0
    pci_hotplug 32056 1 shpchp
    button 11680 0
    evdev 14208 4
    ext3 124688 7
    jbd 51240 1 ext3
    mbcache 12804 1 ext3
    dm_mirror 20608 0
    dm_log 13956 1 dm_mirror
    dm_snapshot 19400 0
    dm_mod 58864 4 dm_crypt,dm_mirror,dm_log,dm_snapshot
    raid10 23680 6
    raid1 24192 2
    md_mod 80164 10 raid10,raid1
    ide_cd_mod 36360 0
    cdrom 37928 1 ide_cd_mod
    floppy 61672 0
    ehci_hcd 36108 0
    uhci_hcd 25760 0
    via82cxxx 12164 0 [permanent]
    ide_pci_generic 9220 0 [permanent]
    ide_core 128284 3 ide_cd_mod,via82cxxx,ide_pci_generic
    ata_generic 10116 0
    skge 41744 0
    via_rhine 25864 0
    mii 9856 1 via_rhine
    ohci1394 32564 0
    ieee1394 93816 1 ohci1394
    sd_mod 29376 35
    thermal 22688 0
    processor 42304 1 thermal
    fan 9352 0
    thermal_sys 17728 4 video,thermal,processor,fan
    sata_promise 16516 15
    sata_via 13060 16
    libata 165472 3 ata_generic,sata_promise,sata_via
    scsi_mod 160760 3 usb_storage,sd_mod,libata
    dock 14112 1 libata

    -- /etc/kernel-img.conf
    do_symlinks = no
    do_bootloader = no
    do_bootfloppy = no
    do_initrd = yes
    postinst_hook = update-grub
    postrm_hook = update-grub

    -- /etc/initramfs-tools/initramfs.conf
    MODULES=most
    BUSYBOX=y
    KEYMAP=n
    BOOT=local
    DEVICE=eth0
    NFSROOT=auto

    -- /etc/crypttab
    #


    -- System Information:
    Debian Release: lenny/sid
    APT prefers unstable
    APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
    Architecture: amd64 (x86_64)

    Kernel: Linux 2.6.26-1-amd64 (SMP w/1 CPU core)
    Locale: LANG=en_GB, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
    Shell: /bin/sh linked to /bin/dash

    Versions of packages initramfs-tools depends on:
    ii cpio 2.9-14 GNU cpio -- a program to manage ar
    ii findutils 4.4.0-2 utilities for finding files--find,
    ii klibc-utils 1.5.12-2 small utilities built with klibc f
    ii module-init-tools 3.4-1 tools for managing Linux kernel mo
    ii udev 0.125-7 /dev/ and hotplug management daemo

    Versions of packages initramfs-tools recommends:
    ii busybox 1:1.10.2-2 Tiny utilities for small and embed

    initramfs-tools suggests no packages.

    -- no debconf information


    --
    .''`. martin f. krafft
    : :' : proud Debian developer, author, administrator, and user
    `. `'` http://people.debian.org/~madduck - http://debiansystem.info
    `- Debian - when you have better things to do than fixing systems

    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v1.4.9 (GNU/Linux)

    iEYEARECAAYFAkjzCFUACgkQIgvIgzMMSnVWwACgqtav6YN43E uivu7lYigwZtgk
    KcAAoMs/1UB24qXts55HwkhqsUDGepue
    =xU1d
    -----END PGP SIGNATURE-----


  2. Bug#502058: maybe_break fails if $break is undefined

    At 1223886933 time_t, martin f krafft wrote:
    > The workaround for mdadm in this case is to pass break=top at the
    > kernel boot prompt, and then hit ^D (ctrl-d) when initramfs-tools
    > presents the shell.
    >
    > Julien, can you please confirm that this works when you get home
    > tonight?


    Unable to confirm that this work: keyboard was not functionning when
    initramfs dropped the shell.

    However patching as described earlier do the trick.

    Cheers,
    --
    Julien Danjou
    .''`. Debian Developer
    : :' : http://julien.danjou.info
    `. `' http://people.debian.org/~acid
    `- 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD

    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v1.4.9 (GNU/Linux)

    iEYEARECAAYFAkj0gWkACgkQpGK1HsL+5c2GDACfU8/FgblQEAlV3ndILjW6KP86
    r/IAoNEE1o8ycKdHUECZaTCwwQcuI6mk
    =MR+R
    -----END PGP SIGNATURE-----


+ Reply to Thread