On Wed, 27 Feb 2008, Luke Yelavich wrote:

> Attached is a patch to fix a possible ro_bootcheck error. The Ubuntu changelog contains the following:
>
> * Fix broken test in ro_boot_check (LP: #187282). It was matching ro as a subword.
>
> The patch applies against git head. See Ubuntu bug #187282,
> https://launchpad.net/bugs/187282 for more information.


yes the test got bogus by kernel upstream adding more info to
/proc/mounts. although current version in debian is fine too.

> - boot_opts=$(awk '/boot/{if ((match($4, /^ro/) || match($4, /,ro/)) \
> - && $2 == "/boot") print "ro"}' /proc/mounts)
> + boot_opts=$(awk '/boot/{if (match($4, /([^a-zA-Z0-9]|^)ro([^a-zA-Z0-9]|$)/) && $2 == "/boot") print "ro"}' /proc/mounts)


hmmm don't see that as improvement, debians version seems more readble.
if you have futher enhancements to it please base the patches on it.

the only trouble on the debian side would be another mount option
beginning with ro, but that didn't get reported yet nor do i know one.

thanks.



--
To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org