Bug#447326: pkgsel: add support for pre-hooks - Debian

This is a discussion on Bug#447326: pkgsel: add support for pre-hooks - Debian ; Package: pkgsel Version: 0.15 Severity: wishlist Tags: patch This patch adds an /usr/lib/pre-pkgsel.d/ directory where hooks can be added in a run-parts fashion. popcon handling has been factored out into its own script in this directory. My main motivation for ...

+ Reply to Thread
Results 1 to 7 of 7

Thread: Bug#447326: pkgsel: add support for pre-hooks

  1. Bug#447326: pkgsel: add support for pre-hooks

    Package: pkgsel
    Version: 0.15
    Severity: wishlist
    Tags: patch

    This patch adds an /usr/lib/pre-pkgsel.d/ directory where hooks can be
    added in a run-parts fashion. popcon handling has been factored out
    into its own script in this directory.

    My main motivation for this patch is that I wanted the ability to
    install a package containing a task definition into /target just
    before tasksel gets executed.

    --
    dann frazier



  2. Bug#447326: pkgsel: add support for pre-hooks

    dann frazier writes:

    > Package: pkgsel
    > Version: 0.15
    > Severity: wishlist
    > Tags: patch
    >
    > This patch adds an /usr/lib/pre-pkgsel.d/ directory where hooks can be
    > added in a run-parts fashion. popcon handling has been factored out
    > into its own script in this directory.


    I personally like the idea and it's really useful to be added. The
    only thing I found, that could be improved, is it to use sorting when
    calling the scripts so you have an expected order respected as it
    being done on other hooks directories like finish-install.d and like.

    For popcon I'd suggest to use 10popcon script name so people can put
    something before it to be called easily.

    --
    O T A V I O S A L V A D O R
    ---------------------------------------------
    E-mail: otavio@debian.org UIN: 5906116
    GNU/Linux User: 239058 GPG ID: 49A5F855
    Home Page: http://otavio.ossystems.com.br
    ---------------------------------------------
    "Microsoft sells you Windows ... Linux gives
    you the whole house."



    --
    To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
    with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

  3. Bug#447326: pkgsel: add support for pre-hooks

    dann frazier wrote:
    > This patch adds an /usr/lib/pre-pkgsel.d/ directory where hooks can be
    > added in a run-parts fashion. popcon handling has been factored out
    > into its own script in this directory.
    >
    > My main motivation for this patch is that I wanted the ability to
    > install a package containing a task definition into /target just
    > before tasksel gets executed.


    Couldn't you get the same effect by using apt-install in
    pressed/early_command, or in a hook in /usr/lib/base-installer.d?

    Or does this need to happen after apt-setup?

    The patch is fine for small hooks, but doesn't advance the progress bar
    between hooks as base-installer does, so would be problimatic if any
    hooks took long.

    --
    see shy jo

    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v1.4.6 (GNU/Linux)

    iD8DBQFHGpE0d8HHehbQuO8RAvcTAKDnR4J5bcONvhNivY1tG2 3X25ZXfgCgpl3w
    T6B45+MD8KnzH2/gI5EKNsE=
    =vO1J
    -----END PGP SIGNATURE-----


  4. Bug#447326: pkgsel: add support for pre-hooks

    Joey Hess writes:

    > The patch is fine for small hooks, but doesn't advance the progress bar
    > between hooks as base-installer does, so would be problimatic if any
    > hooks took long.


    What if we do same thing as finish-install does to support progress on
    the hooks? Then it would be OK for commiting from your side?

    --
    O T A V I O S A L V A D O R
    ---------------------------------------------
    E-mail: otavio@debian.org UIN: 5906116
    GNU/Linux User: 239058 GPG ID: 49A5F855
    Home Page: http://otavio.ossystems.com.br
    ---------------------------------------------
    "Microsoft sells you Windows ... Linux gives
    you the whole house."



    --
    To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
    with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

  5. Bug#447326: pkgsel: add support for pre-hooks

    On Sat, Oct 20, 2007 at 07:37:25PM -0400, Joey Hess wrote:
    > dann frazier wrote:
    > > This patch adds an /usr/lib/pre-pkgsel.d/ directory where hooks can be
    > > added in a run-parts fashion. popcon handling has been factored out
    > > into its own script in this directory.
    > >
    > > My main motivation for this patch is that I wanted the ability to
    > > install a package containing a task definition into /target just
    > > before tasksel gets executed.

    >
    > Couldn't you get the same effect by using apt-install in
    > pressed/early_command, or in a hook in /usr/lib/base-installer.d?
    >
    > Or does this need to happen after apt-setup?


    Exactly. I use an apt-setup generator to add a repository that
    includes my custom task package, so this must happen afterwards.

    In sarge I stored the deb including the task definition in the initrd
    and installed it w/ a late-command. This obviously doesn't work now
    that tasksel runs before the late-command. This revised method also
    avoids the sync problem with the task definition in the initrd and the
    one on the mirror.

    > The patch is fine for small hooks, but doesn't advance the progress bar
    > between hooks as base-installer does, so would be problimatic if any
    > hooks took long.


    I haven't messed w/ progress bar stuff much, but I'll look into adding
    this support.

    Thanks for the review.

    --
    dann frazier




    --
    To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
    with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

  6. Bug#447326: pkgsel: add support for pre-hooks

    On Sat, Oct 20, 2007 at 11:31:17AM -0200, Otavio Salvador wrote:
    > For popcon I'd suggest to use 10popcon script name so people can put
    > something before it to be called easily.


    Yes, that makes sense.

    --
    dann frazier




    --
    To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
    with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

  7. Bug#447326: marked as done (pkgsel: add support for pre-hooks)

    Your message dated Mon, 12 Nov 2007 13:02:06 +0000
    with message-id
    and subject line Bug#447326: fixed in pkgsel 0.16
    has caused the attached Bug report to be marked as done.

    This means that you claim that the problem has been dealt with.
    If this is not the case it is now your responsibility to reopen the
    Bug report if necessary, and/or fix the problem forthwith.

    (NB: If you are a system administrator and have no idea what I am
    talking about this indicates a serious mail system misconfiguration
    somewhere. Please contact me immediately.)

    Debian bug tracking system administrator
    (administrator, Debian Bugs database)



+ Reply to Thread