severity 251023 wishlist
thanks

On Thu, Mar 22, 2007 at 11:07:06AM +0100, Sjoerd Simons wrote:
> Setting this to severity important so it gets considered for the next kernel
> upload.

It was not considered upstream, so it violates our patch policy.

Bastian

--
"That unit is a woman."
"A mass of conflicting impulses."
-- Spock and Nomad, "The Changeling", stardate 3541.9


--
To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

Processing commands for control@bugs.debian.org:

> severity 251023 wishlist
Bug#251023: [PATCH] An initrd level patch for customized DSDT
Severity set to `wishlist' from `important'

> thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

severity 251023 important
reassign 251023 linux-2.6
stop

On Fri, Mar 23, 2007 at 02:07:52PM +0100, Bastian Blank wrote:
> severity 251023 wishlist
> thanks
>
> On Thu, Mar 22, 2007 at 11:07:06AM +0100, Sjoerd Simons wrote:
> > Setting this to severity important so it gets considered for the next kernel
> > upload.
>
> It was not considered upstream, so it violates our patch policy.

i agree that it was rejected upstream, but
* the patch is in any major distro out there
* userspace is not available that early
=> dsdt needs to be loaded before driver initialization
aka before the ACPI engine starts executing
* it helps our users
=> no need to recompile kernel to update dsdt
* many fixed dsdt are available for download


--
maks


--
To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

On Thu, Mar 22, 2007 at 11:07:06AM +0100, Sjoerd Simons wrote:
> So the patch is really the last bit that needs to be added

I did a quick review of the last two versions (0.8.2 and 0.8.3) of the
patch.
- (0.8.2) Moves acpi init into init thread.
- (0.8.3) Populates rootfs two times.
- Uses vfs directly, not the sys_* wrappers. The rootfs code already uses
sys_*, so it seems to be safe. The patch does not document why it does
this that way.
- Introduces a global variable. It does not seem to be necessary. None
of the functions is exported.
- Memory leak. Only one exit path of the override table loader code is
checked.
- Control flow in the loader code is rather weird. It should be readable
from the top to the bottom, not the other way.
- I was not able to find a changelog.

This does not met linux quality standards.

Bastian

--
Live long and prosper.
-- Spock, "Amok Time", stardate 3372.7


--
To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

On Fri, Mar 23, 2007 at 09:46:03PM +0100, Bastian Blank wrote:

Linux head moved the rootfs initialization just before the device
initcalls with the following message:
| Make sure we populate the initroot filesystem late enough
|
| We should not initialize rootfs before all the core initializers have
| run. So do it as a separate stage just before starting the regular
| driver initializers.

This looks like it is not safe to move this further to the beginning.

Bastian

--
Virtue is a relative term.
-- Spock, "Friday's Child", stardate 3499.1


--
To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org