Bug#251023: [PATCH] An initrd level patch for customized DSDT - Debian

This is a discussion on Bug#251023: [PATCH] An initrd level patch for customized DSDT - Debian ; severity 251023 important thanks, On Wed, May 26, 2004 at 01:42:47PM +0200, Francesco P. Lovergine wrote: > Package: kernel-image > Severity: wishlist > Tags: patch > > Please consider > > http://gaugusch.at/kernel.shtml > > as a possible stock kernel patch ...

+ Reply to Thread
Results 1 to 6 of 6

Thread: Bug#251023: [PATCH] An initrd level patch for customized DSDT

  1. Bug#251023: [PATCH] An initrd level patch for customized DSDT

    severity 251023 important
    thanks,

    On Wed, May 26, 2004 at 01:42:47PM +0200, Francesco P. Lovergine wrote:
    > Package: kernel-image
    > Severity: wishlist
    > Tags: patch
    >
    > Please consider
    >
    > http://gaugusch.at/kernel.shtml
    >
    > as a possible stock kernel patch to correct optionally on-fly broken ACPI
    > DSDTs. A kernel-patch package could also be considered, but I see no reason
    > to not provide this optional overriding by default. A mkinitrd patch could
    > also be introduced to add the table to the initrd image.


    Setting this to severity important so it gets considered for the next kernel
    upload.

    Imho it's important, as it allows people with broken ACPI bioses to fix them
    without a kernel recompile. The initramfs tools already have the necessary
    support to include a custom DSTDT into the initrd.

    So the patch is really the last bit that needs to be added

    Sjoerd
    --
    In order to discover who you are, first learn who everybody else is;
    you're what's left.


    --
    To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
    with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

  2. Bug#251023: [PATCH] An initrd level patch for customized DSDT

    severity 251023 wishlist
    thanks

    On Thu, Mar 22, 2007 at 11:07:06AM +0100, Sjoerd Simons wrote:
    > Setting this to severity important so it gets considered for the next kernel
    > upload.


    It was not considered upstream, so it violates our patch policy.

    Bastian

    --
    "That unit is a woman."
    "A mass of conflicting impulses."
    -- Spock and Nomad, "The Changeling", stardate 3541.9


    --
    To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
    with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

  3. Processed: Re: Bug#251023: [PATCH] An initrd level patch for customized DSDT

    Processing commands for control@bugs.debian.org:

    > severity 251023 wishlist

    Bug#251023: [PATCH] An initrd level patch for customized DSDT
    Severity set to `wishlist' from `important'

    > thanks

    Stopping processing here.

    Please contact me if you need assistance.

    Debian bug tracking system administrator
    (administrator, Debian Bugs database)


    --
    To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
    with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

  4. Bug#251023: [PATCH] An initrd level patch for customized DSDT

    severity 251023 important
    reassign 251023 linux-2.6
    stop

    On Fri, Mar 23, 2007 at 02:07:52PM +0100, Bastian Blank wrote:
    > severity 251023 wishlist
    > thanks
    >
    > On Thu, Mar 22, 2007 at 11:07:06AM +0100, Sjoerd Simons wrote:
    > > Setting this to severity important so it gets considered for the next kernel
    > > upload.

    >
    > It was not considered upstream, so it violates our patch policy.


    i agree that it was rejected upstream, but
    * the patch is in any major distro out there
    * userspace is not available that early
    => dsdt needs to be loaded before driver initialization
    aka before the ACPI engine starts executing
    * it helps our users
    => no need to recompile kernel to update dsdt
    * many fixed dsdt are available for download


    --
    maks


    --
    To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
    with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

  5. Bug#251023: [PATCH] An initrd level patch for customized DSDT

    On Thu, Mar 22, 2007 at 11:07:06AM +0100, Sjoerd Simons wrote:
    > So the patch is really the last bit that needs to be added


    I did a quick review of the last two versions (0.8.2 and 0.8.3) of the
    patch.
    - (0.8.2) Moves acpi init into init thread.
    - (0.8.3) Populates rootfs two times.
    - Uses vfs directly, not the sys_* wrappers. The rootfs code already uses
    sys_*, so it seems to be safe. The patch does not document why it does
    this that way.
    - Introduces a global variable. It does not seem to be necessary. None
    of the functions is exported.
    - Memory leak. Only one exit path of the override table loader code is
    checked.
    - Control flow in the loader code is rather weird. It should be readable
    from the top to the bottom, not the other way.
    - I was not able to find a changelog.

    This does not met linux quality standards.

    Bastian

    --
    Live long and prosper.
    -- Spock, "Amok Time", stardate 3372.7


    --
    To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
    with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

  6. Bug#251023: [PATCH] An initrd level patch for customized DSDT

    On Fri, Mar 23, 2007 at 09:46:03PM +0100, Bastian Blank wrote:

    Linux head moved the rootfs initialization just before the device
    initcalls with the following message:
    | Make sure we populate the initroot filesystem late enough
    |
    | We should not initialize rootfs before all the core initializers have
    | run. So do it as a separate stage just before starting the regular
    | driver initializers.

    This looks like it is not safe to move this further to the beginning.

    Bastian

    --
    Virtue is a relative term.
    -- Spock, "Friday's Child", stardate 3499.1


    --
    To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
    with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

+ Reply to Thread